From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
hugh@veritas.com, hch@infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EXPORTFS: Don't return NULL from fh_to_dentry()/fh_to_parent() [ver #4]
Date: Tue, 9 Dec 2008 04:52:10 -0500 [thread overview]
Message-ID: <20081209095209.GA8599@infradead.org> (raw)
In-Reply-To: <20081205174228.GC29227@fieldses.org>
On Fri, Dec 05, 2008 at 12:42:28PM -0500, J. Bruce Fields wrote:
> Not of fh_to_dentry(), but it looks like fh_to_parent() is the same. So
> you'd want the below.
>
> This is partially reverting 440037287c5, which appears to have also do
> some changing of NULLs to ESTALEs which we might also want to reconsider
> at some point. Maybe Christoph could explain what the rationale was.
Miklos suggested always returning ERR_PTR values instead of a a min
or NULLs and ERR_PTR values to make the interface cleaner. I tend
to agree, but botched up the conversion.
next prev parent reply other threads:[~2008-12-09 9:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 16:23 [PATCH] EXPORTFS: Don't return NULL from fh_to_dentry()/fh_to_parent() [ver #4] David Howells
2008-12-05 16:39 ` Hugh Dickins
2008-12-05 16:52 ` Linus Torvalds
2008-12-05 17:42 ` J. Bruce Fields
2008-12-09 9:52 ` Christoph Hellwig [this message]
2008-12-05 18:49 ` David Howells
2008-12-05 19:02 ` Linus Torvalds
2008-12-08 23:24 ` [PATCH] EXPORTFS: handle NULL returns from fh_to_dentry()/fh_to_parent() J. Bruce Fields
2008-12-09 10:30 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081209095209.GA8599@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=dhowells@redhat.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox