From: Jason Baron <jbaron@redhat.com>
To: Greg KH <gregkh@suse.de>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, rostedt@goodmis.org,
fweisbec@gmail.com
Subject: Re: [rfc] [patch] hook tracer to dynamic debug
Date: Tue, 9 Dec 2008 11:27:45 -0500 [thread overview]
Message-ID: <20081209162745.GA3107@redhat.com> (raw)
In-Reply-To: <20081207054840.GA20541@suse.de>
On Sat, Dec 06, 2008 at 09:48:40PM -0800, Greg KH wrote:
> On Fri, Dec 05, 2008 at 02:39:28PM -0500, Jason Baron wrote:
> > hi,
> >
> > Currently, the dynamic debug framework uses 'printk' for output. Here,
> > i've hooked the backend of the dynamic debug framework to the tracing
> > framework. This allows the dynamic debug output to be seaprated from the
> > system log, and allows for higher performance.
>
> Is this really an issue most of the time?
>
> I know logs can get full, but this seems like a bit of an overkill :)
>
> > I've implemented it as a compile time option, but a user might want to
> > be able to toggle b/w 'printk' and the tracer at run-time...other
> > ideas? Patch is against the -tip tree...
>
> It would have to be a run-time option if you want any distro to ever be
> able to enable this in their kernels.
>
There haven't been any specfic complaints about this, although the all
'on' case does really spew quite a lot into the logs. Using Frederic's
suggestion I'm able to implement this with only a few lines of code...so
I'll keep it around if we ever need it...
thanks,
-Jason
prev parent reply other threads:[~2008-12-09 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 19:39 [rfc] [patch] hook tracer to dynamic debug Jason Baron
2008-12-06 13:48 ` Frederic Weisbecker
2008-12-07 5:48 ` Greg KH
2008-12-09 16:27 ` Jason Baron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081209162745.GA3107@redhat.com \
--to=jbaron@redhat.com \
--cc=fweisbec@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox