Re: [PATCH] USB: use stack allocation for struct usb_ctrlrequest

Robert Hancock
2008-12-11T01:00:21Z

Wu Fengguang wrote:
>> In many cases there is no problem to DMA high memory. If you happen to
>> be working with a device that does have problems with full 32 bit
>> addresses then GFP_DMA would be the right flag, not GFP_NOIO.
>
> For 64bit systems, we can easily go beyond 4GB physical memory.
> So at least we should add GFP_DMA32 in addition to GFP_NOIO?

No. The DMA mapping API handles either setting up the IOMMU or doing
software bounce buffering to handle the DMA transfer regardless of where
the memory is located, so drivers don't need to mess with GFP_DMA32.