Re: [PATCH] USB: use stack allocation for struct usb_ctrlrequest

Gilad Ben-Yossef
2008-12-10T14:07:32Z

Wu Fengguang wrote:

> Hi Laurent,
>
> On Wed, Dec 10, 2008 at 11:40:09AM +0200, Laurent Pinchart wrote:
>
>> Hi Wu,
>>
>> On Wednesday 10 December 2008, Wu Fengguang wrote:
>>
>>> sizeof(struct usb_ctrlrequest) = 8, which is as small as the *dt pointer
>>> in a 64bit system.
>>>
>> The usb_ctrlrequest pointer is passed down to the hardware and must point to
>> DMA-able memory. For this reason you can't use the stack and must kmalloc()
>> the structure.
>>
>
> Ah thanks for the background. Does GFP_NOIO guarantee that?
>
No, GFP_NOIO means - do not generate block IO operations (e.g. move
pages to swap, sync dirty buffers to permanent storage etc.) in order to
fulfill this allocation.

The reason for this flag here is presumably that such block IO
operations may very cause USB transaction of the very same kind we're
trying to service now, which can easily get us to a loop.
> e.g. what if the memory is allocated from ZONE_HIGHMEM?
>
In many cases there is no problem to DMA high memory. If you happen to
be working with a device that does have problems with full 32 bit
addresses then GFP_DMA would be the right flag, not GFP_NOIO.

Cheers,
Gilad

--
Gilad Ben-Yossef
Chief Coffee Drinker

Codefidence Ltd.
The code is free, your time isn't.(TM)

Web: http://codefidence.com
Email: gilad@codefidence.com
Office: +972-8-9316883 ext. 201
Fax: +972-8-9316885
Mobile: +972-52-8260388

The Doctor: Don't worry, Reinette, just a nightmare.
Everyone has nightmares. Even monsters from under the
bed have nightmares, don't you, monster?
Reinette: What do monsters have nightmares about?
The Doctor: Me!