From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org, Matt Mackall <mpm@selenic.com>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH] Do not pass the SLAB flags as GFP in slob kmem_cache_create
Date: Wed, 10 Dec 2008 23:23:55 +0300 [thread overview]
Message-ID: <20081210202355.GC2215@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.0812101411020.15262@quilx.com>
[Christoph Lameter - Wed, Dec 10, 2008 at 02:11:23PM -0600]
| On Wed, 10 Dec 2008, Cyrill Gorcunov wrote:
|
| > this would make the following line in slob_alloc
| >
| > ...
| > if (unlikely((gfp & __GFP_ZERO) && b))
| > memset(b, 0, size);
| > ...
| >
| > useless. Not sure if it will be good :)
|
| No. GFP_ZERO is set when kmalloc etc is called. Its not set on
| kmem_cache_create.
|
yep, Matt already pointed, I just missed first time.
- Cyrill -
next prev parent reply other threads:[~2008-12-10 20:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 17:36 [PATCH] Do not pass the SLAB flags as GFP in slob kmem_cache_create Catalin Marinas
2008-12-10 19:34 ` Cyrill Gorcunov
2008-12-10 19:57 ` Matt Mackall
2008-12-10 20:06 ` Cyrill Gorcunov
2008-12-10 20:11 ` Christoph Lameter
2008-12-10 20:23 ` Cyrill Gorcunov [this message]
2008-12-10 19:58 ` Matt Mackall
2008-12-11 9:31 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081210202355.GC2215@localhost \
--to=gorcunov@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox