From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Vorobiev Dmitri <dmitri.vorobiev@movial.fi>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Julia Lawall <julia@diku.dk>,
gregkh@suse.de, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/28] drivers/base/platform.c: Drop return value from platform_driver remove functions
Date: Thu, 11 Dec 2008 00:26:59 +0300 [thread overview]
Message-ID: <20081210212659.GA6132@zarina> (raw)
In-Reply-To: <45755.88.114.236.15.1228932236.squirrel@webmail.movial.fi>
On Wed, Dec 10, 2008 at 08:03:56PM +0200, Vorobiev Dmitri wrote:
> > On Wed, 10 Dec 2008 17:26:26 +0100 (CET)
> > Julia Lawall <julia@diku.dk> wrote:
> >
> >> From: Julia Lawall <julia@diku.dk>
> >>
> >> The return value of the remove function of a driver structure, and thus
> >> of
> >> a platform_driver structure, is ultimately ignored
> >
> > Currently
>
> Are there really any plans about actually using the return value?
It's often used by the drivers, but currently not handled by
the subsystem. For example, _remove() callback might return -EBUSY
or -EAGAIN, which means that whoever called the _remove() should
try later.
For example see drivers/mfd/asic3.c. The driver registers GPIO
chips, on _remove() it *tries* to unregister these chips, but
it could fail (when provided GPIOs are in use by somebody -- it
might be in-kernel users, or sysfs users).
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2008-12-10 21:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 16:26 [PATCH 1/28] drivers/base/platform.c: Drop return value from platform_driver remove functions Julia Lawall
2008-12-10 16:38 ` Alan Cox
2008-12-10 18:03 ` Vorobiev Dmitri
2008-12-10 21:26 ` Anton Vorontsov [this message]
2008-12-10 22:06 ` Vorobiev Dmitri
2008-12-10 22:48 ` Anton Vorontsov
2008-12-10 17:28 ` Mike Frysinger
2008-12-10 22:18 ` Vorobiev Dmitri
2008-12-10 22:37 ` Mike Frysinger
2008-12-12 5:17 ` Greg KH
2008-12-12 11:00 ` Dmitri Vorobiev
2008-12-17 21:38 ` Greg KH
2008-12-12 21:00 ` Mike Frysinger
2008-12-17 21:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081210212659.GA6132@zarina \
--to=cbouatmailru@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dmitri.vorobiev@movial.fi \
--cc=gregkh@suse.de \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox