From: Greg KH <gregkh@suse.de>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Zachary Amsden <zach@vmware.com>,
Huang Ying <ying.huang@intel.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
"norman@thebacks.co.uk" <norman@thebacks.co.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alok Kataria <alokkataria1@gmail.com>, <bruno.premont@restena.lu>,
"xl@xlsigned.net" <xl@xlsigned.net>,
"dsd@gentoo.org" <dsd@gentoo.org>
Subject: Re: [PATCH] Fix VMI crash on boot in 2.6.27+ kernels
Date: Wed, 10 Dec 2008 19:31:05 -0800 [thread overview]
Message-ID: <20081211033105.GA31972@suse.de> (raw)
In-Reply-To: <49405CB6.6010006@kernel.org>
On Wed, Dec 10, 2008 at 04:20:06PM -0800, Yinghai Lu wrote:
> Zachary Amsden wrote:
> > On Tue, 2008-12-09 at 17:15 -0800, Yinghai Lu wrote:
> >
> >> you can not move that late,
> >>
> >> parse_setup_data==>early_memremap==>__early_ioremap
> >
> > How does this look?
> >
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 9d5674f..4c381cb 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -794,6 +794,11 @@ void __init setup_arch(char **cmdline_p)
> printk(KERN_INFO "Command line: %s\n", boot_command_line);
> #endif
>
> +#ifdef CONFIG_VMI
> + /* VMI may relocate the fixmap; do this before touching ioremap area */
> + vmi_init();
> +#endif
Shouldn't the #ifdef not be needed here if the .h files are set up
properly for the vmi_init prototype? Please try to keep them out of .c
files wherever possible.
thanks,
greg k-h
next prev parent reply other threads:[~2008-12-11 3:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 0:50 [PATCH] Fix VMI crash on boot in 2.6.27+ kernels Zachary Amsden
2008-12-10 0:44 ` Greg KH
2008-12-10 7:30 ` Zachary Amsden
2008-12-10 1:15 ` Yinghai Lu
2008-12-10 1:48 ` H. Peter Anvin
2008-12-10 7:31 ` Zachary Amsden
2008-12-10 9:05 ` H. Peter Anvin
2008-12-10 7:36 ` Zachary Amsden
2008-12-11 0:06 ` Zachary Amsden
2008-12-11 0:20 ` Yinghai Lu
2008-12-11 3:31 ` Greg KH [this message]
2008-12-11 22:23 ` [PATCH] Fix VMI crash on boot in 2.6.27, 2.6.28 kernels Zachary Amsden
2008-12-11 21:45 ` Greg KH
2008-12-11 23:37 ` H. Peter Anvin
2008-12-12 5:37 ` Zachary Amsden
2008-12-11 5:44 ` [PATCH] Fix VMI crash on boot in 2.6.27+ kernels Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081211033105.GA31972@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alokkataria1@gmail.com \
--cc=bruno.premont@restena.lu \
--cc=dsd@gentoo.org \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=norman@thebacks.co.uk \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=xl@xlsigned.net \
--cc=ying.huang@intel.com \
--cc=yinghai@kernel.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox