* [PATCH] fix some code style that line over 80 characters
@ 2008-12-10 13:51 Helight.Xu
2008-12-10 15:01 ` Alexey Dobriyan
0 siblings, 1 reply; 6+ messages in thread
From: Helight.Xu @ 2008-12-10 13:51 UTC (permalink / raw)
To: linux-kernel; +Cc: rmk+kernel
>From 449a3ddd01a98aae9122d5199083f45ab9c98469 Mon Sep 17 00:00:00 2001
From: Zhwen Xu <Helight.Xu@gmail.com>
Date: Wed, 10 Dec 2008 21:29:04 +0800
Subject: [PATCH] fix some code style that line over 80 characters
Signed-off-by: ZhenwenXu <helight.xu@gmail.com>
---
drivers/i2c/busses/i2c-s3c2410.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index c772e02..c466870 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -109,7 +109,8 @@ static inline int s3c24xx_i2c_is2440(struct s3c24xx_i2c *i2c)
* the default if there is none
*/
-static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
+static inline struct
+s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
{
if (dev->platform_data != NULL)
return (struct s3c2410_platform_i2c *)dev->platform_data;
@@ -123,7 +124,8 @@ static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct d
* or zero to mean ok.
*/
-static inline void s3c24xx_i2c_master_complete(struct s3c24xx_i2c *i2c, int ret)
+static inline void
+s3c24xx_i2c_master_complete(struct s3c24xx_i2c *i2c, int ret)
{
dev_dbg(i2c->dev, "master_complete %d\n", ret);
@@ -273,7 +275,8 @@ static inline int is_msgend(struct s3c24xx_i2c *i2c)
* process an interrupt and work out what to do
*/
-static int i2s_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
+static int i2s_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c,
+ unsigned long iicstat)
{
unsigned long tmp;
unsigned char byte;
@@ -502,7 +505,8 @@ static int s3c24xx_i2c_set_master(struct s3c24xx_i2c *i2c)
* this starts an i2c transfer
*/
-static int s3c24xx_i2c_doxfer(struct s3c24xx_i2c *i2c, struct i2c_msg *msgs, int num)
+static int s3c24xx_i2c_doxfer(struct s3c24xx_i2c *i2c,
+ struct i2c_msg *msgs, int num)
{
unsigned long timeout;
int ret;
--
1.5.6.5
--
---------------------------------
Zhenwen Xu - Open and Free
Home Page: http://zhwen.org
My Studio: http://dim4.cn
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] fix some code style that line over 80 characters
2008-12-10 13:51 [PATCH] fix some code style that line over 80 characters Helight.Xu
@ 2008-12-10 15:01 ` Alexey Dobriyan
2008-12-11 7:20 ` Zhenwen Xu
2008-12-18 19:26 ` Randy Dunlap
0 siblings, 2 replies; 6+ messages in thread
From: Alexey Dobriyan @ 2008-12-10 15:01 UTC (permalink / raw)
To: Helight.Xu; +Cc: linux-kernel, rmk+kernel
On Wed, Dec 10, 2008 at 09:51:43PM +0800, Helight.Xu wrote:
> -static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> +static inline struct
> +s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
NAK!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] fix some code style that line over 80 characters
2008-12-10 15:01 ` Alexey Dobriyan
@ 2008-12-11 7:20 ` Zhenwen Xu
2008-12-18 19:26 ` Randy Dunlap
1 sibling, 0 replies; 6+ messages in thread
From: Zhenwen Xu @ 2008-12-11 7:20 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-kernel, rmk+kernel, linux-arm
fix some code style that characters more than 80
in drivers/i2c/busses/i2c-s3c2410.c
>From 449a3ddd01a98aae9122d5199083f45ab9c98469 Mon Sep 17 00:00:00 2001
From: Zhwen Xu <Helight.Xu@gmail.com>
Date: Wed, 10 Dec 2008 21:29:04 +0800
Subject: [PATCH] fix some code style that characters more than 80
Signed-off-by: ZhenwenXu <helight.xu@gmail.com>
---
drivers/i2c/busses/i2c-s3c2410.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index c772e02..c466870 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -109,7 +109,8 @@ static inline int s3c24xx_i2c_is2440(struct s3c24xx_i2c *i2c)
* the default if there is none
*/
-static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
+static inline
+struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
{
if (dev->platform_data != NULL)
return (struct s3c2410_platform_i2c *)dev->platform_data;
@@ -123,7 +124,8 @@ static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct d
* or zero to mean ok.
*/
-static inline void s3c24xx_i2c_master_complete(struct s3c24xx_i2c *i2c, int ret)
+static inline void
+s3c24xx_i2c_master_complete(struct s3c24xx_i2c *i2c, int ret)
{
dev_dbg(i2c->dev, "master_complete %d\n", ret);
@@ -273,7 +275,8 @@ static inline int is_msgend(struct s3c24xx_i2c *i2c)
* process an interrupt and work out what to do
*/
-static int i2s_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
+static int i2s_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c,
+ unsigned long iicstat)
{
unsigned long tmp;
unsigned char byte;
@@ -502,7 +505,8 @@ static int s3c24xx_i2c_set_master(struct s3c24xx_i2c *i2c)
* this starts an i2c transfer
*/
-static int s3c24xx_i2c_doxfer(struct s3c24xx_i2c *i2c, struct i2c_msg *msgs, int num)
+static int s3c24xx_i2c_doxfer(struct s3c24xx_i2c *i2c,
+ struct i2c_msg *msgs, int num)
{
unsigned long timeout;
int ret;
--
1.5.6.5
--
---------------------------------
Zhenwen Xu - Open and Free
Home Page: http://zhwen.org
My Studio: http://dim4.cn
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] fix some code style that line over 80 characters
2008-12-10 15:01 ` Alexey Dobriyan
2008-12-11 7:20 ` Zhenwen Xu
@ 2008-12-18 19:26 ` Randy Dunlap
2008-12-18 19:30 ` Russell King
1 sibling, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2008-12-18 19:26 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Helight.Xu, linux-kernel, rmk+kernel
On Wed, 10 Dec 2008 18:01:16 +0300 Alexey Dobriyan wrote:
> On Wed, Dec 10, 2008 at 09:51:43PM +0800, Helight.Xu wrote:
> > -static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> > +static inline struct
> > +s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
>
> NAK!
OK, but please includes reason(s) for NAKs...
---
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fix some code style that line over 80 characters
2008-12-18 19:26 ` Randy Dunlap
@ 2008-12-18 19:30 ` Russell King
2008-12-19 6:34 ` Zhenwen Xu
0 siblings, 1 reply; 6+ messages in thread
From: Russell King @ 2008-12-18 19:30 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Alexey Dobriyan, Helight.Xu, linux-kernel
On Thu, Dec 18, 2008 at 11:26:17AM -0800, Randy Dunlap wrote:
> On Wed, 10 Dec 2008 18:01:16 +0300 Alexey Dobriyan wrote:
>
> > On Wed, Dec 10, 2008 at 09:51:43PM +0800, Helight.Xu wrote:
> > > -static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> > > +static inline struct
> > > +s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> >
> > NAK!
>
> OK, but please includes reason(s) for NAKs...
I can provide a reason - it splits "struct" and the structure name
across different lines. That manes 'struct s3c2410_platform_i2c'
hard to grep for.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fix some code style that line over 80 characters
2008-12-18 19:30 ` Russell King
@ 2008-12-19 6:34 ` Zhenwen Xu
0 siblings, 0 replies; 6+ messages in thread
From: Zhenwen Xu @ 2008-12-19 6:34 UTC (permalink / raw)
To: Russell King; +Cc: Randy Dunlap, Alexey Dobriyan, linux-kernel
On Thu, Dec 18, 2008 at 07:30:59PM +0000, Russell King wrote:
> On Thu, Dec 18, 2008 at 11:26:17AM -0800, Randy Dunlap wrote:
> > On Wed, 10 Dec 2008 18:01:16 +0300 Alexey Dobriyan wrote:
> >
> > > On Wed, Dec 10, 2008 at 09:51:43PM +0800, Helight.Xu wrote:
> > > > -static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> > > > +static inline struct
> > > > +s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> > >
> > > NAK!
> >
> > OK, but please includes reason(s) for NAKs...
>
> I can provide a reason - it splits "struct" and the structure name
> across different lines. That manes 'struct s3c2410_platform_i2c'
> hard to grep for.
yes, it should be:
static inline
struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
>
> --
> Russell King
> Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
> maintainer of:
--
---------------------------------
Zhenwen Xu - Open and Free
Home Page: http://zhwen.org
My Studio: http://dim4.cn
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-12-19 6:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-10 13:51 [PATCH] fix some code style that line over 80 characters Helight.Xu
2008-12-10 15:01 ` Alexey Dobriyan
2008-12-11 7:20 ` Zhenwen Xu
2008-12-18 19:26 ` Randy Dunlap
2008-12-18 19:30 ` Russell King
2008-12-19 6:34 ` Zhenwen Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox