From: Jean Delvare <khali@linux-fr.org>
To: Jens Axboe <axboe@kernel.dk>,
Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] block: Fix LSF default inconsistency
Date: Thu, 11 Dec 2008 11:16:14 +0100 [thread overview]
Message-ID: <20081211111614.493d2a62@hyperion.delvare> (raw)
Configuration option LSF has a default which contradicts its help
text. The help text says "if unsure, say Y" but there is no explicit
default, and the default default is N.
This inconsistency was introduced by commit
88b9adb073b7a69a54b1b14423103bc24587ebdc. According to the commit
message, we want users to enable this option, so it should default to
Y.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
---
block/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-2.6.28-rc8.orig/block/Kconfig 2008-10-10 09:27:54.000000000 +0200
+++ linux-2.6.28-rc8/block/Kconfig 2008-12-11 11:09:33.000000000 +0100
@@ -60,6 +60,7 @@ config BLK_DEV_IO_TRACE
config LSF
bool "Support for Large Single Files"
depends on !64BIT
+ default y
help
Say Y here if you want to be able to handle very large files (2TB
and larger), otherwise say N.
--
Jean Delvare
next reply other threads:[~2008-12-11 10:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 10:16 Jean Delvare [this message]
2008-12-11 10:41 ` [PATCH] block: Fix LSF default inconsistency Jens Axboe
2008-12-11 10:58 ` Jean Delvare
2008-12-11 11:08 ` Jens Axboe
2008-12-11 11:33 ` KOSAKI Motohiro
2008-12-11 11:36 ` Jens Axboe
2008-12-11 11:44 ` KOSAKI Motohiro
2008-12-12 7:58 ` Jens Axboe
2008-12-12 13:50 ` Rik van Riel
2008-12-12 15:11 ` KOSAKI Motohiro
2008-12-12 16:01 ` Hugh Dickins
2008-12-12 16:35 ` Rik van Riel
2008-12-12 17:37 ` Hugh Dickins
2008-12-12 18:00 ` Rik van Riel
2008-12-12 19:26 ` Hugh Dickins
2008-12-11 12:44 ` Jean Delvare
2008-12-11 12:50 ` Jens Axboe
2008-12-12 7:48 ` Jean Delvare
2008-12-12 7:54 ` Jens Axboe
2008-12-12 9:41 ` Jean Delvare
2008-12-12 18:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081211111614.493d2a62@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=Trond.Myklebust@netapp.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox