From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: jeff@garzik.org, linux-kernel@vger.kernel.org,
jirislaby@gmail.com, jgarzik@redhat.com, a_romanescu@yahoo.co.uk,
tj@kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 1/2] DMI: add dmi_match
Date: Thu, 11 Dec 2008 12:29:12 -0800 [thread overview]
Message-ID: <20081211122912.58eb164e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1228855948-22886-1-git-send-email-jirislaby@gmail.com>
On Tue, 9 Dec 2008 21:52:27 +0100
Jiri Slaby <jirislaby@gmail.com> wrote:
>
> +/**
> + * dmi_match - compare string to the dmi field (if exists)
> + *
> + * Returns true if requested field equals to str (including NULL).
> + */
Forgot to document the arguments. If you think it matters. (I don't).
> +static inline bool dmi_match(enum dmi_field f, const char *str)
> +{
> + const char *info = dmi_get_system_info(f);
> +
> + if (info == NULL || str == NULL)
> + return info == str;
> +
> + return !strcmp(info, str);
> +}
> +
I suspect we'd have thinner kernel if this wasn't inlined.
prev parent reply other threads:[~2008-12-11 20:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 8:13 [PATCH 1/1] ATA: piix, fix pointer deref on suspend Jiri Slaby
2008-12-03 9:04 ` Tejun Heo
2008-12-03 10:13 ` Alan Cox
2008-12-03 10:39 ` Tejun Heo
2008-12-09 5:47 ` Jeff Garzik
2008-12-09 20:52 ` [PATCH 1/2] DMI: add dmi_match Jiri Slaby
2008-12-09 20:52 ` [PATCH 2/2 v2] ATA: piix, fix pointer deref on suspend Jiri Slaby
2008-12-09 21:29 ` Jeff Garzik
2008-12-09 22:06 ` Jiri Slaby
2008-12-10 13:07 ` [PATCH 1/2] DMI: add dmi_match Jiri Slaby
2008-12-10 13:07 ` [PATCH 2/2] ATA: piix, cleanup dmi strings checking Jiri Slaby
2008-12-29 12:41 ` [PATCH 1/2] DMI: add dmi_match Jeff Garzik
2008-12-11 20:27 ` [PATCH 2/2 v2] ATA: piix, fix pointer deref on suspend Andrew Morton
2008-12-11 20:34 ` Jiri Slaby
2008-12-09 20:59 ` [PATCH 1/2] DMI: add dmi_match Alan Cox
2008-12-10 2:00 ` Tejun Heo
2008-12-11 20:29 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081211122912.58eb164e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a_romanescu@yahoo.co.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=jgarzik@redhat.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox