breakage in linux-next sound/soc/blackfin/bf5xx-i2s.c

breakage in linux-next sound/soc/blackfin/bf5xx-i2s.c

[Mike Frysinger]

your recent change 3f4b783cfd (ASoC: Register platform DAIs) is
incorrect for sound/soc/blackfin/bf5xx-i2s.c.

the change made there:
+static int __devinit bfin_i2s_init(void)
+{
+       return snd_soc_register_dai(&bfin_i2s_dai);
+}
+module_init(bfin_i2s_init);
+
+static void __exit bfin_i2s_exit(void)
+{
+       snd_soc_unregister_dai(&bfin_i2s_dai);
+}
+module_exit(bfin_i2s_exit);

leads to this:
sound/soc/blackfin/bf5xx-i2s.c:294: warning: initialization from
incompatible pointer type
sound/soc/blackfin/bf5xx-i2s.c: In function 'bfin_i2s_init':
sound/soc/blackfin/bf5xx-i2s.c:318: error: 'bfin_i2s_dai' undeclared
(first use in this function)
sound/soc/blackfin/bf5xx-i2s.c:318: error: (Each undeclared identifier
is reported only once
sound/soc/blackfin/bf5xx-i2s.c:318: error: for each function it appears in.)
sound/soc/blackfin/bf5xx-i2s.c: In function 'bfin_i2s_exit':
sound/soc/blackfin/bf5xx-i2s.c:324: error: 'bfin_i2s_dai' undeclared
(first use in this function)
make[3]: *** [sound/soc/blackfin/bf5xx-i2s.o] Error 1
make[2]: *** [sound/soc/blackfin] Error 2
make[1]: *** [sound/soc] Error 2
make: *** [sound] Error 2

since the variable is named "bf5xx_i2s_dai", not "bfin_i2s_dai"
-mike

Re: breakage in linux-next sound/soc/blackfin/bf5xx-i2s.c

[Mark Brown]

On Thu, Dec 11, 2008 at 11:02:24AM -0500, Mike Frysinger wrote:
> your recent change 3f4b783cfd (ASoC: Register platform DAIs) is
> incorrect for sound/soc/blackfin/bf5xx-i2s.c.

Fixed, thanks.

Re: breakage in linux-next sound/soc/blackfin/bf5xx-i2s.c

[Mike Frysinger]

On Thu, Dec 11, 2008 at 11:14, Mark Brown wrote:
> On Thu, Dec 11, 2008 at 11:02:24AM -0500, Mike Frysinger wrote:
>> your recent change 3f4b783cfd (ASoC: Register platform DAIs) is
>> incorrect for sound/soc/blackfin/bf5xx-i2s.c.
>
> Fixed, thanks.

you did the work, thanks for fixin ;)
-mike