* breakage in linux-next sound/soc/blackfin/bf5xx-i2s.c
@ 2008-12-11 16:02 Mike Frysinger
2008-12-11 16:14 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2008-12-11 16:02 UTC (permalink / raw)
To: broonie; +Cc: LKML
your recent change 3f4b783cfd (ASoC: Register platform DAIs) is
incorrect for sound/soc/blackfin/bf5xx-i2s.c.
the change made there:
+static int __devinit bfin_i2s_init(void)
+{
+ return snd_soc_register_dai(&bfin_i2s_dai);
+}
+module_init(bfin_i2s_init);
+
+static void __exit bfin_i2s_exit(void)
+{
+ snd_soc_unregister_dai(&bfin_i2s_dai);
+}
+module_exit(bfin_i2s_exit);
leads to this:
sound/soc/blackfin/bf5xx-i2s.c:294: warning: initialization from
incompatible pointer type
sound/soc/blackfin/bf5xx-i2s.c: In function 'bfin_i2s_init':
sound/soc/blackfin/bf5xx-i2s.c:318: error: 'bfin_i2s_dai' undeclared
(first use in this function)
sound/soc/blackfin/bf5xx-i2s.c:318: error: (Each undeclared identifier
is reported only once
sound/soc/blackfin/bf5xx-i2s.c:318: error: for each function it appears in.)
sound/soc/blackfin/bf5xx-i2s.c: In function 'bfin_i2s_exit':
sound/soc/blackfin/bf5xx-i2s.c:324: error: 'bfin_i2s_dai' undeclared
(first use in this function)
make[3]: *** [sound/soc/blackfin/bf5xx-i2s.o] Error 1
make[2]: *** [sound/soc/blackfin] Error 2
make[1]: *** [sound/soc] Error 2
make: *** [sound] Error 2
since the variable is named "bf5xx_i2s_dai", not "bfin_i2s_dai"
-mike
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: breakage in linux-next sound/soc/blackfin/bf5xx-i2s.c
2008-12-11 16:02 breakage in linux-next sound/soc/blackfin/bf5xx-i2s.c Mike Frysinger
@ 2008-12-11 16:14 ` Mark Brown
2008-12-11 19:57 ` Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2008-12-11 16:14 UTC (permalink / raw)
To: Mike Frysinger; +Cc: LKML
On Thu, Dec 11, 2008 at 11:02:24AM -0500, Mike Frysinger wrote:
> your recent change 3f4b783cfd (ASoC: Register platform DAIs) is
> incorrect for sound/soc/blackfin/bf5xx-i2s.c.
Fixed, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: breakage in linux-next sound/soc/blackfin/bf5xx-i2s.c
2008-12-11 16:14 ` Mark Brown
@ 2008-12-11 19:57 ` Mike Frysinger
0 siblings, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2008-12-11 19:57 UTC (permalink / raw)
To: Mark Brown; +Cc: LKML
On Thu, Dec 11, 2008 at 11:14, Mark Brown wrote:
> On Thu, Dec 11, 2008 at 11:02:24AM -0500, Mike Frysinger wrote:
>> your recent change 3f4b783cfd (ASoC: Register platform DAIs) is
>> incorrect for sound/soc/blackfin/bf5xx-i2s.c.
>
> Fixed, thanks.
you did the work, thanks for fixin ;)
-mike
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-11 19:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-11 16:02 breakage in linux-next sound/soc/blackfin/bf5xx-i2s.c Mike Frysinger
2008-12-11 16:14 ` Mark Brown
2008-12-11 19:57 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox