Re: [patch 68/83] x86: HPET: convert WARN_ON to WARN_ON_ONCE

Greg KH
2008-12-17T18:47:58Z

On Wed, Dec 17, 2008 at 12:03:05PM +0000, Matt Fleming wrote:
> On Wed, Dec 17, 2008 at 12:33:17PM +0100, Takashi Iwai wrote:
> > At Wed, 17 Dec 2008 11:26:25 +0000,
> > Matt Fleming wrote:
> > >
> > > On Thu, Dec 11, 2008 at 11:16:20AM -0800, Greg KH wrote:
> > > > 2.6.27-stable review patch. If anyone has any objections, please let us know.
> > > >
> > > > ------------------
> > > >
> > > > From: Matt Fleming <mjf@gentoo.org>
> > > >
> > > > commit 1de5b0854623d30d01d72cd4ea323eb5f39d1f16 upstream.
> > > >
> > > > It is possible to flood the console with call traces if the WARN_ON
> > > > condition is true because of the frequency with which this function is
> > > > called.
> > > >
> > >
> > > If this commit is going into stable it would be worth adding these
> > > two commits (which are actually the bugfixes).
> > >
> > > 5ceb1a04187553e08c6ab60d30cee7c454ee139a
> > > x86: HPET: enter hpet_interrupt_handler with interrupts disabled
> > >
> > > 89d77a1eb60be916d85d9394bedbfa2037af89c5
> > > x86: HPET: read from HPET_Tn_CMP() not HPET_T0_CMP
> >
> > I think the latter isn't applicable as 2.6.27 supports only T0.
> >
>
> Ah, thanks. I wasn't aware of that.

Ok, so which patch should go into the 2.6.27-stable tree?

thanks,

greg k-h