From: "Ville Syrjälä" <syrjala@sci.fi>
To: Alex Chiang <achiang@hp.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
justin.chen@hp.com, linux-pci <linux-pci@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] PCI Hotplug: acpiphp wants a 64-bit _SUN
Date: Thu, 11 Dec 2008 21:23:56 +0200 [thread overview]
Message-ID: <20081211192356.GS31176@sci.fi> (raw)
In-Reply-To: <20081211181644.GE18309@ldl.fc.hp.com>
On Thu, Dec 11, 2008 at 11:16:44AM -0700, Alex Chiang wrote:
> From: Justin Chen <justin.chen@hp.com>
>
> Certain HP machines require the full 64 bits of _SUN as allowed
> by the ACPI spec. Without this change, we get name collisions in
> the lower 32 bits of the _SUN returned by firmware.
>
> Signed-off-by: Justin Chen <justin.chen@hp.com>
> Signed-off-by: Alex Chiang <achiang@hp.com>
> ---
> diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
> index f9e244d..9bcb6cb 100644
> --- a/drivers/pci/hotplug/acpiphp.h
> +++ b/drivers/pci/hotplug/acpiphp.h
> @@ -113,7 +113,7 @@ struct acpiphp_slot {
>
> u8 device; /* pci device# */
>
> - u32 sun; /* ACPI _SUN (slot unique number) */
> + unsigned long long sun; /* ACPI _SUN (slot unique number) */
Why not make it u64 if that's what ACPI says it should be?
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
next prev parent reply other threads:[~2008-12-11 19:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 18:12 [PATCH 0/2] PCI Hotplug: acpiphp wants a 64-bit _SUN Alex Chiang
2008-12-11 18:16 ` [PATCH 1/2] " Alex Chiang
2008-12-11 18:35 ` Jesse Barnes
2008-12-11 19:03 ` Matthew Wilcox
2008-12-16 18:47 ` Jesse Barnes
2008-12-11 19:23 ` Ville Syrjälä [this message]
2008-12-11 19:27 ` Alex Chiang
2008-12-11 18:17 ` [PATCH 2/2] PCI Hotplug: acpiphp whitespace cleanup Alex Chiang
2008-12-16 20:21 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081211192356.GS31176@sci.fi \
--to=syrjala@sci.fi \
--cc=achiang@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=justin.chen@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox