From: Ingo Molnar <mingo@elte.hu>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "hpa@zytor.com" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"markus.t.metzger@gmail.com" <markus.t.metzger@gmail.com>,
"roland@redhat.com" <roland@redhat.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"eranian@googlemail.com" <eranian@googlemail.com>
Subject: Re: [PATCH] x86, bts: fix build error
Date: Fri, 12 Dec 2008 10:00:23 +0100 [thread overview]
Message-ID: <20081212090023.GC25106@elte.hu> (raw)
In-Reply-To: <928CFBE8E7CB0040959E56B4EA41A77E0CB57BC4@irsmsx504.ger.corp.intel.com>
* Metzger, Markus T <markus.t.metzger@intel.com> wrote:
> >-----Original Message-----
> >From: Ingo Molnar [mailto:mingo@elte.hu]
> >Sent: Freitag, 12. Dezember 2008 08:23
> >To: Metzger, Markus T
>
> > i fixed a build failure via the commit below - but the recursion in
> > that code is really nasty. Could you please clean it all up to plain
> > flat code?
>
> Sure.
>
> How could I find those things myself? Gcc 4.3.0 does not even give a
> warning for a defconfig build. Is there a config option I should set?
Gcc 4.3.0 is too new for that build failure ;-) -tip testing involves
testing with a couple of older compilers as well. This failure was with
4.2.2 iirc.
You generally shouldnt worry about that too much, as long as it built
fine on your config and the code is reasonably clean.
Ingo
next prev parent reply other threads:[~2008-12-12 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 12:49 [patch 2/3] x86, bts: provide in-kernel branch-trace interface Markus Metzger
2008-12-12 7:09 ` Ingo Molnar
2008-12-12 7:23 ` [PATCH] x86, bts: fix build error Ingo Molnar
2008-12-12 8:46 ` Metzger, Markus T
2008-12-12 9:00 ` Ingo Molnar [this message]
2008-12-12 7:11 ` [patch 2/3] x86, bts: provide in-kernel branch-trace interface Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081212090023.GC25106@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=eranian@googlemail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@gmail.com \
--cc=markus.t.metzger@intel.com \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox