From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Mario Schwalbe <schwalbe@inf.tu-dresden.de>
Cc: Richard Purdie <rpurdie@rpsys.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] video: mbp_nvidia_bl: Add support for MacBook 5, MacBook Air 2, and MacBook Pro 5
Date: Fri, 12 Dec 2008 20:56:09 +0000 [thread overview]
Message-ID: <20081212205609.GA28485@srcf.ucam.org> (raw)
In-Reply-To: <4942CE33.2020403@inf.tu-dresden.de>
On Fri, Dec 12, 2008 at 09:48:51PM +0100, Mario Schwalbe wrote:
> Known Bugs:
> * MacBook Pro 5:
> Initial brightness after bootup is the last recently used
> brightness (in Mac OSX), while the firmware reports maximum.
> Impossible to fix.
In that case, why not read the firmware value and then set that
explicitly on driver load? Having the driver be in sync with the
hardware is better than avoiding a brightness change on boot.
> +static int intel_chipset_get_intensity(struct backlight_device *bd)
> {
> outb(0x03, 0xb3);
> outb(0xbf, 0xb2);
> return inb(0xb3) >> 4;
> }
Just to absolutely clarify, this is intel chipset as in motherboard
chipset and not graphics chipset, right? A comment to make that clear
would be good - it left me a little confused at first. Other than that,
it looks good.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-12-12 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 20:48 [PATCH 1/2] video: mbp_nvidia_bl: Add support for MacBook 5, MacBook Air 2, and MacBook Pro 5 Mario Schwalbe
2008-12-12 20:56 ` Matthew Garrett [this message]
2008-12-13 12:04 ` Mario Schwalbe
2008-12-22 17:11 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081212205609.GA28485@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=schwalbe@inf.tu-dresden.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox