From: Evgeniy Polyakov <zbr@ioremap.net>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
viro@ZenIV.linux.org.uk, hch@infradead.org,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [RFC PATCH -v4 05/14] fsnotify: unified filesystem notification backend
Date: Sat, 13 Dec 2008 05:54:17 +0300 [thread overview]
Message-ID: <20081213025417.GC807@ioremap.net> (raw)
In-Reply-To: <20081212215140.27112.67859.stgit@paris.rdu.redhat.com>
Hi.
On Fri, Dec 12, 2008 at 04:51:40PM -0500, Eric Paris (eparis@redhat.com) wrote:
> +DEFINE_MUTEX(fsnotify_grp_mutex);
> +struct srcu_struct fsnotify_grp_srcu_struct;
> +LIST_HEAD(fsnotify_groups);
> +__u64 fsnotify_mask;
Those can be static.
> +struct fsnotify_event *fsnotify_create_event(struct inode *to_tell, __u64 mask, void *data, int data_is)
> +{
> + struct fsnotify_event *event;
> +
> + event = kmem_cache_alloc(event_kmem_cache, GFP_KERNEL);
> + if (!event)
> + return NULL;
> +
> + atomic_set(&event->refcnt, 1);
> +
> + spin_lock_init(&event->lock);
> +
> + event->path.dentry = NULL;
> + event->path.mnt = NULL;
> + event->inode = NULL;
> +
> + INIT_LIST_HEAD(&event->private_data_list);
> +
> + event->to_tell = to_tell;
What prevents this inode to be released?
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-12-13 2:54 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 21:51 [RFC PATCH -v4 00/14] fsnotify, dnotify, and inotify Eric Paris
2008-12-12 21:51 ` [RFC PATCH -v4 01/14] filesystem notification: create fs/notify to contain all fs notification Eric Paris
2008-12-12 21:51 ` [RFC PATCH -v4 02/14] fsnotify: pass a file instead of an inode to open, read, and write Eric Paris
2008-12-12 21:51 ` [RFC PATCH -v4 03/14] fsnotify: sys_execve and sys_uselib do not call into fsnotify Eric Paris
2008-12-12 21:51 ` [RFC PATCH -v4 04/14] fsnotify: use the new open-exec hook for inotify and dnotify Eric Paris
2008-12-13 15:29 ` Christoph Hellwig
2008-12-12 21:51 ` [RFC PATCH -v4 05/14] fsnotify: unified filesystem notification backend Eric Paris
2008-12-13 2:54 ` Evgeniy Polyakov [this message]
2008-12-13 15:01 ` Eric Paris
2008-12-12 21:51 ` [RFC PATCH -v4 06/14] fsnotify: add group priorities Eric Paris
2008-12-12 21:51 ` [RFC PATCH -v4 07/14] fsnotify: add in inode fsnotify markings Eric Paris
2008-12-13 3:07 ` Evgeniy Polyakov
2008-12-13 16:35 ` Eric Paris
2008-12-22 13:43 ` Al Viro
2008-12-22 14:45 ` Eric Paris
2008-12-12 21:51 ` [RFC PATCH -v4 08/14] fsnotify: parent event notification Eric Paris
2008-12-12 21:52 ` [RFC PATCH -v4 09/14] dnotify: reimplement dnotify using fsnotify Eric Paris
2008-12-12 21:52 ` [RFC PATCH -v4 10/14] fsnotify: generic notification queue and waitq Eric Paris
2008-12-12 21:52 ` [RFC PATCH -v4 11/14] fsnotify: include pathnames with entries when possible Eric Paris
2008-12-13 3:19 ` Evgeniy Polyakov
2008-12-13 16:42 ` Eric Paris
2008-12-12 21:52 ` [RFC PATCH -v4 12/14] fsnotify: add correlations between events Eric Paris
2008-12-18 22:28 ` C. Scott Ananian
2008-12-22 2:40 ` Eric Paris
2008-12-22 9:01 ` Evgeniy Polyakov
2008-12-22 20:06 ` C. Scott Ananian
2008-12-12 21:52 ` [RFC PATCH -v4 13/14] inotify: reimplement inotify using fsnotify Eric Paris
2008-12-13 3:22 ` Evgeniy Polyakov
2008-12-13 16:44 ` Eric Paris
2008-12-15 15:48 ` Evgeniy Polyakov
2008-12-12 21:52 ` [RFC PATCH -v4 14/14] shit on top for debugging Eric Paris
2008-12-14 22:40 ` James Morris
2008-12-14 22:47 ` Eric Paris
2008-12-18 23:36 ` [RFC PATCH -v4 00/14] fsnotify, dnotify, and inotify C. Scott Ananian
2008-12-22 3:22 ` Eric Paris
2008-12-22 10:58 ` Niraj Kumar
2008-12-22 19:59 ` C. Scott Ananian
2008-12-22 20:53 ` Eric Paris
2008-12-29 18:19 ` C. Scott Ananian
2008-12-22 21:04 ` Al Viro
2008-12-22 23:08 ` C. Scott Ananian
2008-12-22 23:20 ` Al Viro
2008-12-22 23:21 ` Christoph Hellwig
2008-12-25 18:17 ` C. Scott Ananian
2008-12-25 20:33 ` Al Viro
2008-12-26 0:58 ` C. Scott Ananian
2008-12-26 1:44 ` Al Viro
2008-12-27 21:23 ` C. Scott Ananian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081213025417.GC807@ioremap.net \
--to=zbr@ioremap.net \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=eparis@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox