From: Gregory Petrosyan <gregory.petrosyan@gmail.com>
To: Giangiacomo Mariotti <giangiacomo.mariotti@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Misuse of sizeof
Date: Sat, 13 Dec 2008 19:48:45 +0300 [thread overview]
Message-ID: <20081213164845.GA19407@home> (raw)
In-Reply-To: <2aac3c260812130831m3ec4aa5cm3abd729499727873@mail.gmail.com>
On Sat, Dec 13, 2008 at 05:31:06PM +0100, Giangiacomo Mariotti wrote:
> IMO there's a bug in the use of sizeof in /arch/x86/boot/main.c, it's
> also a strange style.
> - BUILD_BUG_ON(sizeof boot_params != 4096);
> - memcpy(&boot_params.hdr, &hdr, sizeof hdr);
> + BUILD_BUG_ON(sizeof(boot_params) != 4096);
> + memcpy(&boot_params.hdr, &hdr, sizeof(hdr));
The 'sizeof xxx' style is perfectly valid.
Gregory
next prev parent reply other threads:[~2008-12-13 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 16:31 [PATCH] Misuse of sizeof Giangiacomo Mariotti
2008-12-13 16:43 ` Frédéric Weisbecker
2008-12-13 17:33 ` Giangiacomo Mariotti
2008-12-13 16:44 ` Miguel Ojeda
2008-12-13 16:48 ` Gregory Petrosyan [this message]
2008-12-13 16:59 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081213164845.GA19407@home \
--to=gregory.petrosyan@gmail.com \
--cc=giangiacomo.mariotti@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox