From: Greg KH <greg@kroah.com>
To: tom.leiming@gmail.com
Cc: kay.sievers@vrfy.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: don't pass cls->name as format string in sysdev_class_register()
Date: Sat, 13 Dec 2008 10:16:53 -0800 [thread overview]
Message-ID: <20081213181653.GD6953@kroah.com> (raw)
In-Reply-To: <1229164440-4631-1-git-send-email-tom.leiming@gmail.com>
On Sat, Dec 13, 2008 at 06:34:00PM +0800, tom.leiming@gmail.com wrote:
> From: Ming Lei <tom.leiming@gmail.com>
>
> If cls->name contains substring which can be interpreted as
> format,maybe it causes oops, so fix it.
Why not fix the code that would set cls->name to such a wrong field? I
don't see any in-kernel code that does this, do you?
thanks,
greg k-h
prev parent reply other threads:[~2008-12-13 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 10:34 [PATCH] driver core: don't pass cls->name as format string in sysdev_class_register() tom.leiming
2008-12-13 18:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081213181653.GD6953@kroah.com \
--to=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox