Re: [PATCH 1/6] ide: fix setting nIEN on idle devices

Bartlomiej Zolnierkiewicz
2008-12-16T19:15:15Z

On Sunday 14 December 2008, Willy Tarreau wrote:
> Hi Bart,
>
> On Sun, Dec 14, 2008 at 12:39:32AM +0100, Bartlomiej Zolnierkiewicz wrote:
> > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > Subject: [PATCH] ide: fix setting nIEN on idle devices
> >
> > Fix do_ide_request() to operate on previous device / port instead of
> > the current one. The original code was wrong since at least Feb 2002
> > (2.4.0 timeframe).
>
> What could be the impact of this bug ? Should I backport your fix to 2.4 ?

The fix results in better handling of unexpected IRQs on serialized IDE
ports. However since unexpected IRQs coming from a device is not something
we should normally see and I don't recall seeing any bugreports that would
be potentially closed by this fix I don't think that there is an urgent need
to backport it (thanks for caring about 2.4.x users anyway!).

Thanks,
Bart