public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Coly Li <coly.li@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] avoid unnecessary assignment in lookup_bdev()
Date: Sun, 14 Dec 2008 11:12:33 -0800	[thread overview]
Message-ID: <20081214191233.GB31396@kroah.com> (raw)
In-Reply-To: <49455170.6080307@suse.de>

On Mon, Dec 15, 2008 at 02:33:20AM +0800, Coly Li wrote:
> In normal cases, lookup_bdev() should return successfully, therefore it's not a good idea to always
> assign error values before checking truth/false conditions. This patch modifies code to only assign
> error value in necessary false conditions.
> 
> If I missed something, please correct me.

I don't understand, is there some way that the current code could
incorrectly return an error value?

Is your change somehow faster?  I don't think this is on any fast-path
code, right?

thanks,

greg k-h

  reply	other threads:[~2008-12-14 19:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-14 18:33 [PATCH] avoid unnecessary assignment in lookup_bdev() Coly Li
2008-12-14 19:12 ` Greg KH [this message]
2008-12-14 19:30   ` Coly Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081214191233.GB31396@kroah.com \
    --to=greg@kroah.com \
    --cc=coly.li@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox