* [PATCH] sched: Use RCU variant of list traversal in for_each_leaf_rt_rq()
@ 2008-12-15 6:26 Bharata B Rao
2008-12-16 20:39 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Bharata B Rao @ 2008-12-15 6:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Zijlstra, Ingo Molnar
sched: Use RCU variant of list traversal in for_each_leaf_rt_rq()
for_each_leaf_rt_rq() walks an RCU protected list (rq->leaf_rt_rq_list),
but doesn't use list_for_each_entry_rcu(). Fix this.
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
---
kernel/sched_rt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -77,7 +77,7 @@ static inline u64 sched_rt_period(struct
}
#define for_each_leaf_rt_rq(rt_rq, rq) \
- list_for_each_entry(rt_rq, &rq->leaf_rt_rq_list, leaf_rt_rq_list)
+ list_for_each_entry_rcu(rt_rq, &rq->leaf_rt_rq_list, leaf_rt_rq_list)
static inline struct rq *rq_of_rt_rq(struct rt_rq *rt_rq)
{
Regards,
Bharata.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched: Use RCU variant of list traversal in for_each_leaf_rt_rq()
2008-12-15 6:26 [PATCH] sched: Use RCU variant of list traversal in for_each_leaf_rt_rq() Bharata B Rao
@ 2008-12-16 20:39 ` Ingo Molnar
2008-12-17 2:34 ` Bharata B Rao
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2008-12-16 20:39 UTC (permalink / raw)
To: Bharata B Rao; +Cc: linux-kernel, Peter Zijlstra
* Bharata B Rao <bharata@linux.vnet.ibm.com> wrote:
> sched: Use RCU variant of list traversal in for_each_leaf_rt_rq()
>
> for_each_leaf_rt_rq() walks an RCU protected list (rq->leaf_rt_rq_list),
> but doesn't use list_for_each_entry_rcu(). Fix this.
>
> Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> ---
> kernel/sched_rt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to tip/sched/urgent, thanks Bharata!
i'm wondering, have you observed a real crash, or did you find this via
code review?
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched: Use RCU variant of list traversal in for_each_leaf_rt_rq()
2008-12-16 20:39 ` Ingo Molnar
@ 2008-12-17 2:34 ` Bharata B Rao
0 siblings, 0 replies; 3+ messages in thread
From: Bharata B Rao @ 2008-12-17 2:34 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Peter Zijlstra
On Tue, Dec 16, 2008 at 09:39:57PM +0100, Ingo Molnar wrote:
>
> * Bharata B Rao <bharata@linux.vnet.ibm.com> wrote:
>
> > sched: Use RCU variant of list traversal in for_each_leaf_rt_rq()
> >
> > for_each_leaf_rt_rq() walks an RCU protected list (rq->leaf_rt_rq_list),
> > but doesn't use list_for_each_entry_rcu(). Fix this.
> >
> > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> > ---
> > kernel/sched_rt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> applied to tip/sched/urgent, thanks Bharata!
>
> i'm wondering, have you observed a real crash, or did you find this via
> code review?
Via code review.
Thanks,
Bharata.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-17 2:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-15 6:26 [PATCH] sched: Use RCU variant of list traversal in for_each_leaf_rt_rq() Bharata B Rao
2008-12-16 20:39 ` Ingo Molnar
2008-12-17 2:34 ` Bharata B Rao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox