Re: [RFC PATCH crypto] AES: Add support to Intel AES-NI instructions

Herbert Xu
2008-12-15T11:29:16Z

On Mon, Dec 15, 2008 at 10:07:45AM +0100, Sebastian Andrzej Siewior wrote:
>
> You have to it if you want to bypass the crypto layer and call asm
> functions directly and I'm not sure whether bypassing the crypto layer
> is a good thing. Both asm routines (the 32bit and 64bit) assume that
> keylen ist at +0 followed by enc key, dec key. Ach and they don't do the
> ALIGN thing.
>
> Herbert what do you thing?

I think it would be OK if it called the assembly routine directly
and we moved this under asm/x86-64. We should do the latter anyway
regardless of what we decide.

However, I'm skeptical about whether we should use of a fallback at
all rather than making this work in softirq context.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt