From: Rusty Russell <rusty@rustcorp.com.au>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: Avi Kivity <avi@redhat.com>, "kvm-devel" <kvm@vger.kernel.org>,
Rusty Russell <rusty@ozlabs.au.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: use modern cpumask primitives, no cpumask_t on stack
Date: Mon, 15 Dec 2008 19:04:35 +1030 [thread overview]
Message-ID: <200812151904.36554.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1229014284.26586.9.camel@localhost.localdomain>
On Friday 12 December 2008 03:21:24 Hollis Blanchard wrote:
> This patch breaks uniprocessor builds, because smp_call_function_many()
> is only defined for CONFIG_SMP.
Good catch. I missed it because it's fixed as a side-effect of a
later patch in my series (before I convert users).
Linus, can you please apply this fix?
Thanks,
Rusty.
Subject: Define smp_call_function_many for UP
Otherwise those using it in transition patches (eg. kvm) can't compile
with CONFIG_SMP=n:
arch/x86/kvm/../../../virt/kvm/kvm_main.c: In function 'make_all_cpus_request':
arch/x86/kvm/../../../virt/kvm/kvm_main.c:380: error: implicit declaration of function 'smp_call_function_many'
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff --git a/include/linux/smp.h b/include/linux/smp.h
--- a/include/linux/smp.h
+++ b/include/linux/smp.h
@@ -146,6 +147,8 @@ static inline void smp_send_reschedule(i
})
#define smp_call_function_mask(mask, func, info, wait) \
(up_smp_call_function(func, info))
+#define smp_call_function_many(mask, func, info, wait) \
+ (up_smp_call_function(func, info))
static inline void init_call_single_data(void)
{
}
next parent reply other threads:[~2008-12-15 8:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081208160945.7535A25006E@cleopatra.tlv.redhat.com>
[not found] ` <1229014284.26586.9.camel@localhost.localdomain>
2008-12-15 8:34 ` Rusty Russell [this message]
2008-12-18 22:10 ` [PATCH] Define smp_call_function_many for UP Rusty Russell
2008-12-18 22:16 ` Linus Torvalds
2008-12-19 5:43 ` Rusty Russell
2008-12-19 17:03 ` Linus Torvalds
2008-12-21 8:11 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812151904.36554.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=avi@redhat.com \
--cc=hollisb@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@ozlabs.au.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox