From: Andi Kleen <andi@firstfloor.org>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: don't enable MCE after suspend/resume when system was booted with "nomce"
Date: Mon, 15 Dec 2008 23:23:03 +0100 [thread overview]
Message-ID: <20081215222303.GW25779@one.firstfloor.org> (raw)
In-Reply-To: <20081215185503.GA5620@alberich.amd.com>
> > http://git.kernel.org/?p=linux/kernel/git/mingo/linux-2.6-x86.git;a=commit;h=81c7af997dafbabad464ccefba89af2b247899da
>
> Thanks for that pointer.
> I didn't look at tip/x86/mce up to know. Is this .28 material?
I would think so, but I'm not sure the x86 maintainers think the same.
> My fix is intended for .28.
>
> I didn't care about the lurking sysfs interface when booted with
> "nomce". It's there and you could enable MCE with changing attributes
> but then you are actively fiddling with MCE.
>
> The fix is for the more severe problem that mce_init() is called on
> resume and thus will enable MCE (setup cr4 and corresponding MSRs)
> which shouldn't happen when booted with "nomce".
The patch does the same (although the description doesn't say that).
When there is no sysfs interface there won't
be any resume either because resume goes through the sysdev devices.
So it's a cleaner and more complete fix imho.
-Andi
next prev parent reply other threads:[~2008-12-15 22:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 18:06 [PATCH 0/2] x86: mcheck: suspend/resume bug fixes Andreas Herrmann
2008-12-12 18:08 ` [PATCH 1/2] x86: don't enable MCE after suspend/resume when system was booted with "nomce" Andreas Herrmann
2008-12-12 19:08 ` Andi Kleen
2008-12-15 18:55 ` Andreas Herrmann
2008-12-15 22:23 ` Andi Kleen [this message]
2008-12-12 18:10 ` [PATCH 2/2] x86: re-enable MCE on secondary CPUS after suspend/resume Andreas Herrmann
2008-12-12 19:06 ` Andi Kleen
2008-12-15 19:05 ` Andreas Herrmann
2008-12-15 22:33 ` Andi Kleen
2008-12-15 22:41 ` Andreas Herrmann
2008-12-16 22:03 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081215222303.GW25779@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=andreas.herrmann3@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox