public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben-linux@fluff.org>
To: linux-kernel@vger.kernel.org
Subject: driver probe error reporting
Date: Mon, 15 Dec 2008 23:15:02 +0000	[thread overview]
Message-ID: <20081215231502.GC12431@fluff.org.uk> (raw)

This runs on from the discussion in [1] on how drivers (especially
one using a variant of the device driver framework) report errors
on probe. There are two main classes of errors, the type which happen
at probe time (device not responding, not enough memory, etc) and
errors that are due to configuration such as missing device configuration
data.

It has been suggested that using dev_err() to report any configuration
data error is a bloat of code as a properly debugged kernel should never
find itself in this state.

Unfortunatley the only diagnostic dev_xxx() macro is dev_dbg() which is
only available if the the driver code itself defines DEBUG. I would think
it would be better to have a macro that can be turned on/off by a kernel
configuration for when debugging which turns on the messages that are
important to developers creating new machine/arch support but disabled
for shipping kernels.

Basically, what are people's thoughts on a "Verbose probe error"
configuration option in the "Kernel hacking" submenu with its own
dev_probe_err() or similar macro?


[1] http://groups.google.com/group/fa.linux.kernel/browse_thread/thread/ce6260537381dd94/7ed3f699db907357?show_docid=7ed3f699db907357

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

             reply	other threads:[~2008-12-15 23:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-15 23:15 Ben Dooks [this message]
2008-12-17  6:36 ` driver probe error reporting Greg KH
2008-12-17 12:44   ` Rafael J. Wysocki
2008-12-17 18:24     ` Greg KH
2008-12-17 21:44       ` Rafael J. Wysocki
2008-12-17 21:53         ` Greg KH
2008-12-17 23:05           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081215231502.GC12431@fluff.org.uk \
    --to=ben-linux@fluff.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox