public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Alex Chiang <achiang@hp.com>,
	justin.chen@hp.com, "linux-pci" <linux-pci@vger.kernel.org>,
	"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] PCI Hotplug: acpiphp wants a 64-bit _SUN
Date: Tue, 16 Dec 2008 10:47:24 -0800	[thread overview]
Message-ID: <200812161047.24759.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20081211190346.GD26095@parisc-linux.org>

On Thursday, December 11, 2008 11:03 am Matthew Wilcox wrote:
> On Thu, Dec 11, 2008 at 10:35:01AM -0800, Jesse Barnes wrote:
> > On Thursday, December 11, 2008 10:16 am Alex Chiang wrote:
> > > From: Justin Chen <justin.chen@hp.com>
> > >
> > > Certain HP machines require the full 64 bits of _SUN as allowed
> > > by the ACPI spec. Without this change, we get name collisions in
> > > the lower 32 bits of the _SUN returned by firmware.
> > >
> > > Signed-off-by: Justin Chen <justin.chen@hp.com>
> > > Signed-off-by: Alex Chiang <achiang@hp.com>
> >
> > It's very late in the cycle, so I'd like to get acks from at least a
> > couple of other testers for this one...  Any volunteers?
>
> Testers or reviewers?  Here's my review (done thinking out loud style):

Well, review is good too; I stuffed this one into my for-linus branch (the 
whitespace one went into linux-next), thanks for checking it out.

-- 
Jesse Barnes, Intel Open Source Technology Center


  reply	other threads:[~2008-12-16 18:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-11 18:12 [PATCH 0/2] PCI Hotplug: acpiphp wants a 64-bit _SUN Alex Chiang
2008-12-11 18:16 ` [PATCH 1/2] " Alex Chiang
2008-12-11 18:35   ` Jesse Barnes
2008-12-11 19:03     ` Matthew Wilcox
2008-12-16 18:47       ` Jesse Barnes [this message]
2008-12-11 19:23   ` Ville Syrjälä
2008-12-11 19:27     ` Alex Chiang
2008-12-11 18:17 ` [PATCH 2/2] PCI Hotplug: acpiphp whitespace cleanup Alex Chiang
2008-12-16 20:21   ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812161047.24759.jbarnes@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=achiang@hp.com \
    --cc=justin.chen@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox