From: Arnd Bergmann <arnd@arndb.de>
To: JosephChan@via.com.tw
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch 3/3] via-sdmmc: via-sdmmc.h
Date: Tue, 16 Dec 2008 13:25:58 +0100 [thread overview]
Message-ID: <200812161325.58594.arnd@arndb.de> (raw)
In-Reply-To: <C80EF34A3D2E494DBAF9AC29C7AE4EB808520F3C@exchtp03.taipei.via.com.tw>
On Tuesday 16 December 2008, JosephChan@via.com.tw wrote:
> Header file of VIA MSP SD/MMC card reader driver.
>
The order of your patches is reversed, you add the Kconfig/Makefile
changes last so that the tree stays 'bisectable', i.e. you don't
have a broken build in the middle between your patches.
Since your header file is not an interface but only used in a single
source file, I would also suggest merging it into the main via-sdmmc.c
file, add changing Kconfig/Makefile in the same patch.
Arnd <><
next prev parent reply other threads:[~2008-12-16 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 11:41 [Patch 3/3] via-sdmmc: via-sdmmc.h JosephChan
2008-12-16 12:25 ` Arnd Bergmann [this message]
2008-12-17 11:14 ` JosephChan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812161325.58594.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=JosephChan@via.com.tw \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox