From: Ben Dooks <ben-linux@fluff.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Ben Dooks <ben-linux@fluff.org>,
Hannes Eder <hannes@hanneseder.net>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] HID: avoid sparse warning in HID_COMPAT_LOAD_DRIVER
Date: Tue, 16 Dec 2008 19:41:13 +0000 [thread overview]
Message-ID: <20081216194113.GF12431@fluff.org.uk> (raw)
In-Reply-To: <alpine.LNX.1.10.0812161659580.21089@jikos.suse.cz>
On Tue, Dec 16, 2008 at 05:01:38PM +0100, Jiri Kosina wrote:
> On Tue, 16 Dec 2008, Ben Dooks wrote:
>
> > > #ifdef CONFIG_HID_COMPAT
> > > #define HID_COMPAT_LOAD_DRIVER(name) \
> > > +/* prototype to avoid sparse warning */ \
> > > +extern void hid_compat_##name(void); \
> > > void hid_compat_##name(void) { } \
> > surely this could simply be changed to 'static void
> > hid_compat_##name(void)' if it is only being defined to be an empty
>
> This will cause gcc emit warnings about unused symbols.
sorry, 'static inline void' then.
> --
> Jiri Kosina
> SUSE Labs
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2008-12-16 19:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 12:31 [PATCH] HID: avoid sparse warning in HID_COMPAT_LOAD_DRIVER Hannes Eder
2008-12-16 13:35 ` Jiri Kosina
2008-12-16 15:58 ` Ben Dooks
2008-12-16 16:01 ` Jiri Kosina
2008-12-16 19:41 ` Ben Dooks [this message]
2008-12-16 19:44 ` Hannes Eder
2008-12-19 8:31 ` Jiri Slaby
2008-12-19 9:37 ` Jiri Kosina
2008-12-20 16:55 ` Jiri Slaby
2009-02-06 16:07 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081216194113.GF12431@fluff.org.uk \
--to=ben-linux@fluff.org \
--cc=hannes@hanneseder.net \
--cc=jkosina@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox