From: Jens Axboe <jens.axboe@oracle.com>
To: scameron@beardog.cca.cpqcorp.net
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mikem@roadking.cca.cpqcorp.net
Subject: Re: [patch] cciss: Fix problem that deleting multiple logical drives could cause a panic
Date: Tue, 16 Dec 2008 21:27:30 +0100 [thread overview]
Message-ID: <20081216202730.GZ32491@kernel.dk> (raw)
In-Reply-To: <20081216201703.GL1126@beardog.cca.cpqcorp.net>
On Tue, Dec 16 2008, scameron@beardog.cca.cpqcorp.net wrote:
>
> Fix problem that deleting multiple logical drives could cause a panic.
This looks like a 2.6.28 candidate, correct?
>
> Signed-off-by: Stephen M. Cameron <scameron@beardog.cca.cpqcorp.net>
> ---
>
> drivers/block/cciss.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff -puN drivers/block/cciss.c~fix_rebuild_lun_table_bug drivers/block/cciss.c
> --- linux-2.6.28-rc8/drivers/block/cciss.c~fix_rebuild_lun_table_bug 2008-12-16 14:00:52.000000000 -0600
> +++ linux-2.6.28-rc8-root/drivers/block/cciss.c 2008-12-16 14:00:52.000000000 -0600
> @@ -1693,6 +1693,11 @@ static int rebuild_lun_table(ctlr_info_t
> for (i = 0; i <= h->highest_lun; i++) {
> int j;
> drv_found = 0;
> +
> + /* skip holes in the array from already deleted drives */
> + if (h->drv[i].raid_level == -1)
> + continue;
> +
> for (j = 0; j < num_luns; j++) {
> memcpy(&lunid, &ld_buff->LUN[j][0], 4);
> lunid = le32_to_cpu(lunid);
> _
--
Jens Axboe
next prev parent reply other threads:[~2008-12-16 20:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 20:17 [patch] cciss: Fix problem that deleting multiple logical drives could cause a panic scameron
2008-12-16 20:27 ` Jens Axboe [this message]
2008-12-16 20:49 ` scameron
2008-12-18 13:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081216202730.GZ32491@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikem@roadking.cca.cpqcorp.net \
--cc=scameron@beardog.cca.cpqcorp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox