From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: make sure we really have an hpet mapping before using it
Date: Tue, 16 Dec 2008 21:48:29 +0100 [thread overview]
Message-ID: <20081216204829.GD14787@elte.hu> (raw)
In-Reply-To: <49481057.2030307@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> When booting in Xen dom0, the hpet isn't really accessible, so make
> sure the mapping is non-NULL before use.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> ---
> arch/x86/kernel/hpet.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> ===================================================================
> --- a/arch/x86/kernel/hpet.c
> +++ b/arch/x86/kernel/hpet.c
> @@ -818,9 +818,10 @@
>
> hpet_address = force_hpet_address;
> hpet_enable();
> - if (!hpet_virt_address)
> - return -ENODEV;
> }
> +
> + if (!hpet_virt_address)
> + return -ENODEV;
hm, how can hpet_virt_address become non-NULL if hpet_address is zero?
Ingo
next prev parent reply other threads:[~2008-12-16 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 20:32 [PATCH] x86: make sure we really have an hpet mapping before using it Jeremy Fitzhardinge
2008-12-16 20:48 ` Ingo Molnar [this message]
2008-12-16 20:59 ` Jeremy Fitzhardinge
2008-12-16 21:02 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081216204829.GD14787@elte.hu \
--to=mingo@elte.hu \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox