From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] sched: Use RCU variant of list traversal in for_each_leaf_rt_rq()
Date: Wed, 17 Dec 2008 08:04:53 +0530 [thread overview]
Message-ID: <20081217023453.GA4146@in.ibm.com> (raw)
In-Reply-To: <20081216203957.GB14787@elte.hu>
On Tue, Dec 16, 2008 at 09:39:57PM +0100, Ingo Molnar wrote:
>
> * Bharata B Rao <bharata@linux.vnet.ibm.com> wrote:
>
> > sched: Use RCU variant of list traversal in for_each_leaf_rt_rq()
> >
> > for_each_leaf_rt_rq() walks an RCU protected list (rq->leaf_rt_rq_list),
> > but doesn't use list_for_each_entry_rcu(). Fix this.
> >
> > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> > ---
> > kernel/sched_rt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> applied to tip/sched/urgent, thanks Bharata!
>
> i'm wondering, have you observed a real crash, or did you find this via
> code review?
Via code review.
Thanks,
Bharata.
prev parent reply other threads:[~2008-12-17 2:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 6:26 [PATCH] sched: Use RCU variant of list traversal in for_each_leaf_rt_rq() Bharata B Rao
2008-12-16 20:39 ` Ingo Molnar
2008-12-17 2:34 ` Bharata B Rao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081217023453.GA4146@in.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox