Re: [PATCH] sched: Use RCU variant of list traversal in for_each_leaf_rt_rq()

Bharata B Rao
2008-12-17T02:35:23Z

On Tue, Dec 16, 2008 at 09:39:57PM +0100, Ingo Molnar wrote:
>
> * Bharata B Rao <bharata@linux.vnet.ibm.com> wrote:
>
> > sched: Use RCU variant of list traversal in for_each_leaf_rt_rq()
> >
> > for_each_leaf_rt_rq() walks an RCU protected list (rq->leaf_rt_rq_list),
> > but doesn't use list_for_each_entry_rcu(). Fix this.
> >
> > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> > ---
> > kernel/sched_rt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> applied to tip/sched/urgent, thanks Bharata!
>
> i'm wondering, have you observed a real crash, or did you find this via
> code review?

Via code review.

Thanks,
Bharata.