From: Al Viro <viro@ZenIV.linux.org.uk>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: jdike@addtoit.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] get rid of the last symlink in uml build
Date: Wed, 17 Dec 2008 09:10:58 +0000 [thread overview]
Message-ID: <20081217091058.GB28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20081217085539.GA4152@uranus.ravnborg.org>
On Wed, Dec 17, 2008 at 09:55:39AM +0100, Sam Ravnborg wrote:
> > AFAICS, having archprepare depend on user_constants.h and kern_constants.h
> > would do just fine. Note that we don't care how these two are ordered;
> > it's asm-offsets.h that can't be created without user_constants.h.
>
> Agreed.
>
> Previously we had some race issues in the arch Makefile when they used
> the prepare target and they were workaround in various ways.
> This was why we introduced archprepare in the first place IIRC.
> And I also recall that um was starnge but this is all cleaned up now - good.
FWIW, how do you plan to deal with include/asm once everything gets moved
to arch/*/include/asm?
Right now O=... builds create asm-offsets.h in $(objtree)/include/asm; do
you plan to take it to $(objtree)/arch/$(ARCH)/include/asm?
Another bloody annoying thing is dangling include2/asm on such builds, along
with include/asm-x86 created on non-O=.. ones.
If/when we stop doing that and just put asm-offsets.h into arch/*/include/asm
we'll need to update the rule for kern_constants.h to
$(SHARED_HEADERS)/kern_constants.h:
$(Q)mkdir -p $(dir $@)
$(Q)echo '#include "../asm/asm-offsets.h"' >$@
Not a big deal, just something that'll need to be taken care of when we
switch...
next prev parent reply other threads:[~2008-12-17 9:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 6:12 [PATCH] get rid of the last symlink in uml build Al Viro
2008-12-17 7:26 ` Sam Ravnborg
2008-12-17 8:37 ` Al Viro
2008-12-17 8:55 ` Sam Ravnborg
2008-12-17 9:10 ` Al Viro [this message]
2008-12-17 11:27 ` Sam Ravnborg
2008-12-17 17:02 ` Al Viro
2008-12-17 17:18 ` Sam Ravnborg
2008-10-06 7:03 ` Greg Ungerer
2009-01-12 10:16 ` Sam Ravnborg
2008-12-17 17:33 ` Al Viro
2008-12-17 17:35 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081217091058.GB28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox