From: Al Viro <viro@ZenIV.linux.org.uk>
To: James Morris <jmorris@namei.org>
Cc: Al Viro <viro@ftp.linux.org.uk>,
linux-audit@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/15] sanitize AUDIT_MQ_SENDRECV
Date: Wed, 17 Dec 2008 09:40:15 +0000 [thread overview]
Message-ID: <20081217094015.GD28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LRH.1.10.0812171839080.22856@tundra.namei.org>
On Wed, Dec 17, 2008 at 06:40:54PM +1100, James Morris wrote:
> On Wed, 17 Dec 2008, Al Viro wrote:
>
> >
> > * logging the original value of *msg_prio in mq_timedreceive(2)
> > is insane - the argument is write-only (i.e. syscall always
> > ignores the original value and only overwrites it).
>
> I wonder if any existing certifications need to be amended.
I rather doubt it, but I really don't know the bureaucracy of that.
Just to clarify:
Old code logs the value of *msg_prio; that value is always
ignored by syscall (it may store something there, but that's it -
pure output parameter)
New code does not change the format of log message; the value
in that field of the message is replaced with 0. That's the only
difference.
Whether that requires amending of the existing certs... bugger if I know.
next prev parent reply other threads:[~2008-12-17 9:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 5:12 [PATCH 7/15] sanitize AUDIT_MQ_SENDRECV Al Viro
2008-12-17 7:40 ` James Morris
2008-12-17 9:40 ` Al Viro [this message]
2008-12-17 7:56 ` Andrew Morton
2008-12-17 8:03 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081217094015.GD28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jmorris@namei.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox