From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 01/15] kmemleak: Add the base support
Date: Wed, 17 Dec 2008 09:15:42 -0800 [thread overview]
Message-ID: <20081217171542.GC6674@linux.vnet.ibm.com> (raw)
In-Reply-To: <1229507096.32517.8.camel@pc1117.cambridge.arm.com>
On Wed, Dec 17, 2008 at 09:44:56AM +0000, Catalin Marinas wrote:
> On Tue, 2008-12-16 at 11:36 -0800, Paul E. McKenney wrote:
> > On Wed, Dec 10, 2008 at 06:26:59PM +0000, Catalin Marinas wrote:
> > > This patch adds the base support for the kernel memory leak
> > > detector. It traces the memory allocation/freeing in a way similar to
> > > the Boehm's conservative garbage collector, the difference being that
> > > the unreferenced objects are not freed but only shown in
> > > /sys/kernel/debug/memleak. Enabling this feature introduces an
> > > overhead to memory allocations.
> >
> > Looks good to me from an RCU viewpoint!
> >
> > Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> Thanks for reviewing it.
>
> FYI, in the version I'm going to post this week I added another mutex to
> ensure the exclusive opening of the /sys/kernel/debug/memleak file as
> one can now use this file to configure kmemleak at run-time. The RCU
> locking isn't affected and I'll add your "Reviewed-by:" line.
Fair enough!
Thanx, Paul
next prev parent reply other threads:[~2008-12-17 17:21 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 18:26 [PATCH 00/15] Kernel memory leak detector Catalin Marinas
2008-12-10 18:26 ` [PATCH 01/15] kmemleak: Add the base support Catalin Marinas
2008-12-11 22:01 ` Pekka Enberg
2008-12-12 11:36 ` Catalin Marinas
2008-12-12 13:14 ` Pekka Enberg
2008-12-16 19:36 ` Paul E. McKenney
2008-12-17 9:44 ` Catalin Marinas
2008-12-17 17:15 ` Paul E. McKenney [this message]
2008-12-10 18:27 ` [PATCH 02/15] kmemleak: Add documentation on the memory leak detector Catalin Marinas
2008-12-10 18:27 ` [PATCH 03/15] kmemleak: Add the slab memory allocation/freeing hooks Catalin Marinas
2008-12-10 18:32 ` Dave Hansen
2008-12-10 18:53 ` Dave Hansen
2008-12-11 21:22 ` Pekka Enberg
2008-12-12 14:27 ` Catalin Marinas
2008-12-18 10:46 ` Pekka Enberg
2008-12-18 16:38 ` Catalin Marinas
2008-12-18 16:49 ` Christoph Lameter
2008-12-18 17:02 ` Catalin Marinas
2008-12-18 19:35 ` Christoph Lameter
2008-12-18 20:06 ` Pekka Enberg
2008-12-18 21:41 ` Christoph Lameter
2008-12-19 10:44 ` Catalin Marinas
2008-12-10 18:27 ` [PATCH 04/15] kmemleak: Add the slob " Catalin Marinas
2008-12-10 18:36 ` Matt Mackall
2008-12-11 9:47 ` Catalin Marinas
2008-12-11 21:37 ` Pekka Enberg
2008-12-10 18:27 ` [PATCH 05/15] kmemleak: Add the slub " Catalin Marinas
2008-12-11 21:30 ` Pekka Enberg
2008-12-12 13:45 ` Catalin Marinas
2008-12-18 10:51 ` Pekka Enberg
2008-12-18 15:28 ` Catalin Marinas
2008-12-18 16:05 ` Pekka Enberg
2008-12-10 18:27 ` [PATCH 06/15] kmemleak: Add the vmalloc " Catalin Marinas
2008-12-10 18:27 ` [PATCH 07/15] kmemleak: Add memleak_alloc callback from alloc_large_system_hash Catalin Marinas
2008-12-10 19:04 ` Dave Hansen
2008-12-11 9:50 ` Catalin Marinas
2008-12-11 10:08 ` Catalin Marinas
2008-12-11 17:30 ` Dave Hansen
2008-12-11 17:38 ` Catalin Marinas
2008-12-11 17:45 ` Dave Hansen
2008-12-11 19:47 ` Pekka Enberg
2008-12-12 17:04 ` Catalin Marinas
2008-12-12 17:17 ` Dave Hansen
2008-12-12 17:43 ` Catalin Marinas
2008-12-10 18:27 ` [PATCH 08/15] kmemleak: Add modules support Catalin Marinas
2008-12-10 18:27 ` [PATCH 09/15] x86: Provide _sdata in the vmlinux_*.lds.S files Catalin Marinas
2008-12-10 18:27 ` [PATCH 10/15] arm: Provide _sdata and __bss_stop in the vmlinux.lds.S file Catalin Marinas
2008-12-10 18:27 ` [PATCH 11/15] kmemleak: Remove some of the kmemleak false positives Catalin Marinas
2008-12-10 18:28 ` [PATCH 12/15] kmemleak: Enable the building of the memory leak detector Catalin Marinas
2008-12-10 19:20 ` Dave Hansen
2008-12-12 17:27 ` Catalin Marinas
2008-12-12 18:02 ` Dave Hansen
2008-12-10 18:28 ` [PATCH 13/15] kmemleak: Keep the __init functions after initialization Catalin Marinas
2008-12-10 18:44 ` Sam Ravnborg
2008-12-17 13:09 ` Catalin Marinas
2008-12-10 18:28 ` [PATCH 14/15] kmemleak: Simple testing module for kmemleak Catalin Marinas
2008-12-10 18:28 ` [PATCH 15/15] kmemleak: Add the corresponding MAINTAINERS entry Catalin Marinas
2008-12-11 9:44 ` [PATCH 00/15] Kernel memory leak detector Catalin Marinas
-- strict thread matches above, loose matches on Subject: below --
2008-11-29 10:43 Catalin Marinas
2008-11-29 10:43 ` [PATCH 01/15] kmemleak: Add the base support Catalin Marinas
2008-12-01 5:39 ` Yasunori Goto
2008-12-01 6:49 ` Pekka Enberg
2008-12-01 8:11 ` Yasunori Goto
2008-12-01 12:29 ` Catalin Marinas
2008-12-01 7:15 ` Pekka Enberg
2008-12-02 21:28 ` Andrew Morton
2008-12-04 18:50 ` Catalin Marinas
2008-12-04 19:03 ` Andrew Morton
2008-12-18 9:28 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081217171542.GC6674@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox