public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PATCH] driver core fixes for your 2.6-git tree
@ 2008-10-29 22:38 Greg KH
  0 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2008-10-29 22:38 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton; +Cc: linux-kernel

Here are 6 patches for your 2.6-git tree.

They contain:
	- 4 documentation updates:
		- ja_JP/HOWTO update
		- stable_kernel_rules.txt update
		- document the taint flags properly
		- fix some function comments in drivers/base/sys.c that
		  were incorrect.
	- bugfix for the dynamic_printk command line option
	- bugfix for the sysdev code

All of these have been in the -next trees and the -mm releases for a
while now.

Please pull from:
	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/driver-core-2.6.git/

The patches will be sent as a follow-on to this message to lkml for people
to see.

thanks,

greg k-h

------------

 Documentation/ja_JP/HOWTO             |   14 +++++++-------
 Documentation/stable_kernel_rules.txt |    1 +
 Documentation/sysctl/kernel.txt       |   24 +++++++++++++++++-------
 drivers/base/sys.c                    |   10 ++++++----
 lib/dynamic_printk.c                  |    4 +++-
 5 files changed, 34 insertions(+), 19 deletions(-)

---------------

Andi Kleen (1):
      sysfs: Fix return values for sysdev_store_{ulong,int}

Greg Kroah-Hartman (1):
      Document kernel taint flags properly

Jason Baron (1):
      Driver core: fix 'dynamic_debug' cmd line parameter

Josh Boyer (1):
      Update stable tree documentation

Qinghuang Feng (1):
      driver core: drivers/base/sys.c: update comments

Tsugikazu Shibata (1):
      HOWTO: Sync patch for jp_JP/HOWTO


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [GIT PATCH] driver core fixes for your 2.6-git tree
@ 2008-12-17 19:27 Greg KH
  2008-12-17 19:28 ` [PATCH 1/4] driver core: fix using 'ret' variable in unregister_dynamic_debug_module Greg Kroah-Hartman
                   ` (3 more replies)
  0 siblings, 4 replies; 11+ messages in thread
From: Greg KH @ 2008-12-17 19:27 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton; +Cc: linux-kernel

Here are 4 patches for your 2.6-git tree.

They contain:
	- licensing fix for the xilinx_hwicap drivers (signed off by the
	  original authors)
	- 2 dynamic debug printk fixes
	- staging Kconfig fix

All of these have been in the -next trees and the -mm releases for a
while now.

Please pull from:
	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/driver-core-2.6.git/

The patches will be sent as a follow-on to this message to lkml for people
to see.

thanks,

greg k-h

------------

 drivers/char/xilinx_hwicap/buffer_icap.c   |    3 ---
 drivers/char/xilinx_hwicap/buffer_icap.h   |    3 ---
 drivers/char/xilinx_hwicap/fifo_icap.c     |    3 ---
 drivers/char/xilinx_hwicap/fifo_icap.h     |    3 ---
 drivers/char/xilinx_hwicap/xilinx_hwicap.c |    3 ---
 drivers/char/xilinx_hwicap/xilinx_hwicap.h |    3 ---
 drivers/staging/Kconfig                    |    3 +++
 lib/dynamic_printk.c                       |    6 +++---
 8 files changed, 6 insertions(+), 21 deletions(-)

---------------

Dmitry Baryshkov (1):
      STAGING: Move staging drivers back to staging-specific menu

Greg Kroah-Hartman (1):
      xilinx_hwicap: remove improper wording in license statement

Johann Felix Soden (1):
      driver core: fix using 'ret' variable in unregister_dynamic_debug_module

Marcel Holtmann (1):
      driver core: add newlines to debugging enabled/disabled messages


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH 1/4] driver core: fix using 'ret' variable in unregister_dynamic_debug_module
  2008-12-17 19:27 [GIT PATCH] driver core fixes for your 2.6-git tree Greg KH
@ 2008-12-17 19:28 ` Greg Kroah-Hartman
  2008-12-17 19:28 ` [PATCH 2/4] xilinx_hwicap: remove improper wording in license statement Greg Kroah-Hartman
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 11+ messages in thread
From: Greg Kroah-Hartman @ 2008-12-17 19:28 UTC (permalink / raw)
  To: linux-kernel; +Cc: Johann Felix Soden, Greg Kroah-Hartman

From: Johann Felix Soden <johfel@users.sourceforge.net>

The 'ret' variable is assigned, but not used in the return statement. Fix this.

Signed-off-by: Johann Felix Soden <johfel@users.sourceforge.net>
Acked-by: Jason Baron <jbaron@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 lib/dynamic_printk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c
index d83660f..d0fd0e4 100644
--- a/lib/dynamic_printk.c
+++ b/lib/dynamic_printk.c
@@ -135,7 +135,7 @@ int unregister_dynamic_debug_module(char *mod_name)
 	nr_entries--;
 out:
 	up(&debug_list_mutex);
-	return 0;
+	return ret;
 }
 EXPORT_SYMBOL_GPL(unregister_dynamic_debug_module);
 
-- 
1.6.0.4


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 2/4] xilinx_hwicap: remove improper wording in license statement
  2008-12-17 19:27 [GIT PATCH] driver core fixes for your 2.6-git tree Greg KH
  2008-12-17 19:28 ` [PATCH 1/4] driver core: fix using 'ret' variable in unregister_dynamic_debug_module Greg Kroah-Hartman
@ 2008-12-17 19:28 ` Greg Kroah-Hartman
  2008-12-17 23:08   ` Alan Cox
  2008-12-17 19:28 ` [PATCH 3/4] driver core: add newlines to debugging enabled/disabled messages Greg Kroah-Hartman
  2008-12-17 19:28 ` [PATCH 4/4] STAGING: Move staging drivers back to staging-specific menu Greg Kroah-Hartman
  3 siblings, 1 reply; 11+ messages in thread
From: Greg Kroah-Hartman @ 2008-12-17 19:28 UTC (permalink / raw)
  To: linux-kernel; +Cc: Greg Kroah-Hartman, Stephen Neuendorffer, stable

GPLv2 doesn't allow additional restrictions to be imposed on any
code, so this wording needs to be removed from these files.

Signed-off-by: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/char/xilinx_hwicap/buffer_icap.c   |    3 ---
 drivers/char/xilinx_hwicap/buffer_icap.h   |    3 ---
 drivers/char/xilinx_hwicap/fifo_icap.c     |    3 ---
 drivers/char/xilinx_hwicap/fifo_icap.h     |    3 ---
 drivers/char/xilinx_hwicap/xilinx_hwicap.c |    3 ---
 drivers/char/xilinx_hwicap/xilinx_hwicap.h |    3 ---
 6 files changed, 0 insertions(+), 18 deletions(-)

diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c b/drivers/char/xilinx_hwicap/buffer_icap.c
index aa7f796..05d8977 100644
--- a/drivers/char/xilinx_hwicap/buffer_icap.c
+++ b/drivers/char/xilinx_hwicap/buffer_icap.c
@@ -21,9 +21,6 @@
  *     INFRINGEMENT, IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
  *     FOR A PARTICULAR PURPOSE.
  *
- *     Xilinx products are not intended for use in life support appliances,
- *     devices, or systems. Use in such applications is expressly prohibited.
- *
  *     (c) Copyright 2003-2008 Xilinx Inc.
  *     All rights reserved.
  *
diff --git a/drivers/char/xilinx_hwicap/buffer_icap.h b/drivers/char/xilinx_hwicap/buffer_icap.h
index 8b0252b..d4f419e 100644
--- a/drivers/char/xilinx_hwicap/buffer_icap.h
+++ b/drivers/char/xilinx_hwicap/buffer_icap.h
@@ -21,9 +21,6 @@
  *     INFRINGEMENT, IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
  *     FOR A PARTICULAR PURPOSE.
  *
- *     Xilinx products are not intended for use in life support appliances,
- *     devices, or systems. Use in such applications is expressly prohibited.
- *
  *     (c) Copyright 2003-2008 Xilinx Inc.
  *     All rights reserved.
  *
diff --git a/drivers/char/xilinx_hwicap/fifo_icap.c b/drivers/char/xilinx_hwicap/fifo_icap.c
index 776b505..02225eb 100644
--- a/drivers/char/xilinx_hwicap/fifo_icap.c
+++ b/drivers/char/xilinx_hwicap/fifo_icap.c
@@ -21,9 +21,6 @@
  *     INFRINGEMENT, IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
  *     FOR A PARTICULAR PURPOSE.
  *
- *     Xilinx products are not intended for use in life support appliances,
- *     devices, or systems. Use in such applications is expressly prohibited.
- *
  *     (c) Copyright 2007-2008 Xilinx Inc.
  *     All rights reserved.
  *
diff --git a/drivers/char/xilinx_hwicap/fifo_icap.h b/drivers/char/xilinx_hwicap/fifo_icap.h
index 62bda45..4c9dd9a 100644
--- a/drivers/char/xilinx_hwicap/fifo_icap.h
+++ b/drivers/char/xilinx_hwicap/fifo_icap.h
@@ -21,9 +21,6 @@
  *     INFRINGEMENT, IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
  *     FOR A PARTICULAR PURPOSE.
  *
- *     Xilinx products are not intended for use in life support appliances,
- *     devices, or systems. Use in such applications is expressly prohibited.
- *
  *     (c) Copyright 2007-2008 Xilinx Inc.
  *     All rights reserved.
  *
diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c b/drivers/char/xilinx_hwicap/xilinx_hwicap.c
index d161319..f40ab69 100644
--- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c
+++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c
@@ -21,9 +21,6 @@
  *     INFRINGEMENT, IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
  *     FOR A PARTICULAR PURPOSE.
  *
- *     Xilinx products are not intended for use in life support appliances,
- *     devices, or systems. Use in such applications is expressly prohibited.
- *
  *     (c) Copyright 2002 Xilinx Inc., Systems Engineering Group
  *     (c) Copyright 2004 Xilinx Inc., Systems Engineering Group
  *     (c) Copyright 2007-2008 Xilinx Inc.
diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.h b/drivers/char/xilinx_hwicap/xilinx_hwicap.h
index 24d0d9b..8cca119 100644
--- a/drivers/char/xilinx_hwicap/xilinx_hwicap.h
+++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.h
@@ -21,9 +21,6 @@
  *     INFRINGEMENT, IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
  *     FOR A PARTICULAR PURPOSE.
  *
- *     Xilinx products are not intended for use in life support appliances,
- *     devices, or systems. Use in such applications is expressly prohibited.
- *
  *     (c) Copyright 2003-2007 Xilinx Inc.
  *     All rights reserved.
  *
-- 
1.6.0.4


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 3/4] driver core: add newlines to debugging enabled/disabled messages
  2008-12-17 19:27 [GIT PATCH] driver core fixes for your 2.6-git tree Greg KH
  2008-12-17 19:28 ` [PATCH 1/4] driver core: fix using 'ret' variable in unregister_dynamic_debug_module Greg Kroah-Hartman
  2008-12-17 19:28 ` [PATCH 2/4] xilinx_hwicap: remove improper wording in license statement Greg Kroah-Hartman
@ 2008-12-17 19:28 ` Greg Kroah-Hartman
  2008-12-17 19:28 ` [PATCH 4/4] STAGING: Move staging drivers back to staging-specific menu Greg Kroah-Hartman
  3 siblings, 0 replies; 11+ messages in thread
From: Greg Kroah-Hartman @ 2008-12-17 19:28 UTC (permalink / raw)
  To: linux-kernel; +Cc: Marcel Holtmann, Greg Kroah-Hartman

From: Marcel Holtmann <marcel@holtmann.org>

Both messages are missing the newline and thus dmesg output gets
scrambled.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 lib/dynamic_printk.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c
index d0fd0e4..8e30295 100644
--- a/lib/dynamic_printk.c
+++ b/lib/dynamic_printk.c
@@ -289,7 +289,7 @@ static ssize_t pr_debug_write(struct file *file, const char __user *buf,
 					dynamic_enabled = DYNAMIC_ENABLED_SOME;
 					err = 0;
 					printk(KERN_DEBUG
-					       "debugging enabled for module %s",
+					       "debugging enabled for module %s\n",
 					       elem->name);
 				} else if (!value && (elem->enable == 1)) {
 					elem->enable = 0;
@@ -309,7 +309,7 @@ static ssize_t pr_debug_write(struct file *file, const char __user *buf,
 					err = 0;
 					printk(KERN_DEBUG
 					       "debugging disabled for module "
-					       "%s", elem->name);
+					       "%s\n", elem->name);
 				}
 			}
 		}
-- 
1.6.0.4


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 4/4] STAGING: Move staging drivers back to staging-specific menu
  2008-12-17 19:27 [GIT PATCH] driver core fixes for your 2.6-git tree Greg KH
                   ` (2 preceding siblings ...)
  2008-12-17 19:28 ` [PATCH 3/4] driver core: add newlines to debugging enabled/disabled messages Greg Kroah-Hartman
@ 2008-12-17 19:28 ` Greg Kroah-Hartman
  3 siblings, 0 replies; 11+ messages in thread
From: Greg Kroah-Hartman @ 2008-12-17 19:28 UTC (permalink / raw)
  To: linux-kernel; +Cc: Dmitry Baryshkov, Greg Kroah-Hartman

From: Dmitry Baryshkov <dbaryshkov@gmail.com>

Signed-off-by: Dmitry Baryshkov <dbaryshkov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/staging/Kconfig |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index c95b286..5d457c9 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -22,6 +22,8 @@ menuconfig STAGING
 	  If in doubt, say N here.
 
 
+if STAGING
+
 config STAGING_EXCLUDE_BUILD
 	bool "Exclude Staging drivers from being built" if STAGING
 	default y
@@ -62,3 +64,4 @@ source "drivers/staging/at76_usb/Kconfig"
 source "drivers/staging/poch/Kconfig"
 
 endif # !STAGING_EXCLUDE_BUILD
+endif # STAGING
-- 
1.6.0.4


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/4] xilinx_hwicap: remove improper wording in license statement
  2008-12-17 19:28 ` [PATCH 2/4] xilinx_hwicap: remove improper wording in license statement Greg Kroah-Hartman
@ 2008-12-17 23:08   ` Alan Cox
  2008-12-17 23:45     ` Greg KH
  0 siblings, 1 reply; 11+ messages in thread
From: Alan Cox @ 2008-12-17 23:08 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: linux-kernel, Greg Kroah-Hartman, Stephen Neuendorffer, stable

On Wed, 17 Dec 2008 11:28:21 -0800
Greg Kroah-Hartman <gregkh@suse.de> wrote:

> GPLv2 doesn't allow additional restrictions to be imposed on any
> code, so this wording needs to be removed from these files.

You only need to remove the "Use in .. expressly prohibited bit", the
rest seems like useful relevant information.


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/4] xilinx_hwicap: remove improper wording in license statement
  2008-12-17 23:08   ` Alan Cox
@ 2008-12-17 23:45     ` Greg KH
  0 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2008-12-17 23:45 UTC (permalink / raw)
  To: Alan Cox; +Cc: linux-kernel, Stephen Neuendorffer, stable

On Wed, Dec 17, 2008 at 11:08:55PM +0000, Alan Cox wrote:
> On Wed, 17 Dec 2008 11:28:21 -0800
> Greg Kroah-Hartman <gregkh@suse.de> wrote:
> 
> > GPLv2 doesn't allow additional restrictions to be imposed on any
> > code, so this wording needs to be removed from these files.
> 
> You only need to remove the "Use in .. expressly prohibited bit", the
> rest seems like useful relevant information.

As this ended up just being boiler-plate wording from an internal Xilinx
template, and didn't apply at all to these files, it seemed easier to
just remove the whole thing :)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [GIT PATCH] driver core fixes for your 2.6-git tree
@ 2009-01-09 23:20 Greg KH
  0 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2009-01-09 23:20 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton
  Cc: linux-kernel, Stefan Richter, Alan Cox, Kay Sievers

Here are 4 reverts of patches that were previously pulled into your git
tree.  They revert the ability for the driver core to have a private
area in struct device.

Thanks to Stefan Richter for pointing out the problems with the current
implementation, and for Alan Cox persuading me to rework the whole
thing, which I will do for the 2.6.30 release.

Please pull from:
	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/driver-core-2.6.git/

The patches will be sent as a follow-on to this message to lkml for people
to see.

thanks,

greg k-h

------------

 drivers/base/base.h    |   26 --------------------------
 drivers/base/bus.c     |   40 +++++++++++++---------------------------
 drivers/base/core.c    |   45 +++++++++++++--------------------------------
 drivers/base/dd.c      |   13 +++++--------
 drivers/base/driver.c  |   13 +++----------
 include/linux/device.h |    7 ++++---
 6 files changed, 38 insertions(+), 106 deletions(-)

---------------

Greg Kroah-Hartman (4):
      Revert "driver core: move knode_bus into private structure"
      Revert "driver core: move knode_driver into private structure"
      Revert "driver core: move klist_children into private structure"
      Revert "driver core: create a private portion of struct device"


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [GIT PATCH] driver core fixes for your 2.6-git tree
@ 2009-01-21  5:18 Greg KH
  0 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2009-01-21  5:18 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton; +Cc: linux-kernel, Kay Sievers

Here are 5 bugfixes against your current kernel git tree.

They fix the following reported problems:
	- klist blowing up on CRIS architecture
	- some block device names showing up incorrectly due to
	  mishandled ! formatting
	- sysfs binary file bugfix
	- debugfs build breakage if it is disable and wimax is enabled.
	- PNP modules not properly being autoloaded due to lowercase
	  issues in file2alias.c

All of these have been in the last -next release, with the majority of
them in the -next releases for the past week.

Please pull from:
	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/driver-core-2.6.git/

The patches will be sent as a follow-on to this message to lkml for people
to see.

thanks,

greg k-h

------------

 drivers/base/core.c      |    6 ++++++
 fs/sysfs/bin.c           |    6 ++++++
 include/linux/debugfs.h  |    7 +++++++
 include/linux/klist.h    |    2 +-
 scripts/mod/file2alias.c |   17 +++++++++++++++--
 5 files changed, 35 insertions(+), 3 deletions(-)

---------------

Greg Kroah-Hartman (1):
      sysfs: fix problems with binary files

Inaky Perez-Gonzalez (1):
      debugfs: introduce stub for debugfs_create_size_t() when DEBUG_FS=n

Jesper Nilsson (1):
      klist.c: bit 0 in pointer can't be used as flag

Kay Sievers (1):
      PNP: fix broken pnp lowercasing for acpi module aliases

Roland Dreier (1):
      driver core: Convert '/' to '!' in dev_set_name()


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [GIT PATCH] driver core fixes for your 2.6-git tree
@ 2009-01-28 23:25 Greg KH
  0 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2009-01-28 23:25 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton; +Cc: linux-kernel

Here are 3 documentation bugfixes against your current kernel git tree.

All of these have been in the -next releases.

Please pull from:
	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/driver-core-2.6.git/

The patches will be sent as a follow-on to this message to lkml for people
to see.

thanks,

greg k-h

------------

 Documentation/DocBook/uio-howto.tmpl        |   88 +++++++++++++++++++++++++++
 Documentation/ja_JP/stable_kernel_rules.txt |   15 +++--
 drivers/base/core.c                         |    2 +-
 3 files changed, 99 insertions(+), 6 deletions(-)

---------------

Hans J. Koch (1):
      UIO: Add missing documentation of features added recently

Randy Dunlap (1):
      driver-core: fix kernel-doc parameter name

Tsugikazu Shibata (1):
      Sync patch for jp_JP/stable_kernel_rules.txt


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2009-01-28 23:27 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-17 19:27 [GIT PATCH] driver core fixes for your 2.6-git tree Greg KH
2008-12-17 19:28 ` [PATCH 1/4] driver core: fix using 'ret' variable in unregister_dynamic_debug_module Greg Kroah-Hartman
2008-12-17 19:28 ` [PATCH 2/4] xilinx_hwicap: remove improper wording in license statement Greg Kroah-Hartman
2008-12-17 23:08   ` Alan Cox
2008-12-17 23:45     ` Greg KH
2008-12-17 19:28 ` [PATCH 3/4] driver core: add newlines to debugging enabled/disabled messages Greg Kroah-Hartman
2008-12-17 19:28 ` [PATCH 4/4] STAGING: Move staging drivers back to staging-specific menu Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2009-01-28 23:25 [GIT PATCH] driver core fixes for your 2.6-git tree Greg KH
2009-01-21  5:18 Greg KH
2009-01-09 23:20 Greg KH
2008-10-29 22:38 Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox