From: Greg KH <gregkh@suse.de>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Vorobiev Dmitri <dmitri.vorobiev@movial.fi>,
Julia Lawall <julia@diku.dk>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/28] drivers/base/platform.c: Drop return value from platform_driver remove functions
Date: Wed, 17 Dec 2008 13:37:45 -0800 [thread overview]
Message-ID: <20081217213745.GC26923@suse.de> (raw)
In-Reply-To: <8bd0f97a0812121300p6c509336pde936b7f8c5ca6a@mail.gmail.com>
On Fri, Dec 12, 2008 at 04:00:02PM -0500, Mike Frysinger wrote:
> On Fri, Dec 12, 2008 at 00:17, Greg KH wrote:
> > On Wed, Dec 10, 2008 at 05:37:42PM -0500, Mike Frysinger wrote:
> >> On Wed, Dec 10, 2008 at 17:18, Vorobiev Dmitri wrote:
> >> >> On Wed, Dec 10, 2008 at 11:26, Julia Lawall wrote:
> >> >> you'll get a
> >> >> warning in C about the assignment, but you wont get a build failure,
> >> >
> >> > ...unless you compile with -Werror, which frequently the case.
> >>
> >> anyone crazy enough to build with -Werror is crazy enough to send in a fix ;)
> >
> > Hm, have you noted that some arches have that flag enabled in their
> > build?
>
> i dont see anyone building things beyond a select dir or two (none of
> which contain platform drivers) with -Werror. where are you seeing
> this ?
Sparc builds add this from what I remember, I've broken their build at
times by adding unnecessary errors and got an inbox full of emails about
it :)
thanks,
greg k-h
prev parent reply other threads:[~2008-12-17 21:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 16:26 [PATCH 1/28] drivers/base/platform.c: Drop return value from platform_driver remove functions Julia Lawall
2008-12-10 16:38 ` Alan Cox
2008-12-10 18:03 ` Vorobiev Dmitri
2008-12-10 21:26 ` Anton Vorontsov
2008-12-10 22:06 ` Vorobiev Dmitri
2008-12-10 22:48 ` Anton Vorontsov
2008-12-10 17:28 ` Mike Frysinger
2008-12-10 22:18 ` Vorobiev Dmitri
2008-12-10 22:37 ` Mike Frysinger
2008-12-12 5:17 ` Greg KH
2008-12-12 11:00 ` Dmitri Vorobiev
2008-12-17 21:38 ` Greg KH
2008-12-12 21:00 ` Mike Frysinger
2008-12-17 21:37 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081217213745.GC26923@suse.de \
--to=gregkh@suse.de \
--cc=dmitri.vorobiev@movial.fi \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox