From: Evgeniy Polyakov <zbr@ioremap.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [w1] Allow master IO commands.
Date: Thu, 18 Dec 2008 02:19:41 +0300 [thread overview]
Message-ID: <20081217231941.GA29798@ioremap.net> (raw)
In-Reply-To: <20081217151418.f17cee7c.akpm@linux-foundation.org>
On Wed, Dec 17, 2008 at 03:14:18PM -0800, Andrew Morton (akpm@linux-foundation.org) wrote:
> Do we have checks in there to ensure that we can't run off the end of
> the buffer?
Yes, w1_process_search_command() calls w1_search_devices() with the
w1_send_slave() callback which is invoked each time new slave is
detected. w1_send_slave() checks if amount of available data is enough
to store additional ID and sends message otherwise. The last message is
being sent with the flag indicating that, and it is sent no matter if
there were some slave devices found or not.
> > Ok, I will space it to the left. Should I sent patch on top of it or
> > instead of?
>
> Is OK, I'll fix it. That change messes up the following patches so I
> fixed them as well.
Thanks a lot Andrew!
--
Evgeniy Polyakov
prev parent reply other threads:[~2008-12-17 23:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 18:07 [w1] userspace commands extensions Evgeniy Polyakov
2008-12-16 18:07 ` [w1] Allow master IO commands Evgeniy Polyakov
2008-12-16 18:08 ` [w1] Move w1 commands from defines to enum Evgeniy Polyakov
2008-12-16 18:08 ` [w1] Added w1 reset command Evgeniy Polyakov
2008-12-16 18:08 ` [w1] Send status messages after command processing Evgeniy Polyakov
2008-12-17 22:22 ` [w1] Allow master IO commands Andrew Morton
2008-12-17 22:33 ` Evgeniy Polyakov
2008-12-17 23:14 ` Andrew Morton
2008-12-17 23:19 ` Evgeniy Polyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081217231941.GA29798@ioremap.net \
--to=zbr@ioremap.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox