From: Pavel Machek <pavel@suse.cz>
To: Andi Kleen <andi@firstfloor.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Allow HPET force enable on ICH10 HPET
Date: Thu, 18 Dec 2008 08:33:04 +0100 [thread overview]
Message-ID: <20081218073304.GA2110@ucw.cz> (raw)
In-Reply-To: <20081216013547.GA24992@basil.nowhere.org>
On Tue 2008-12-16 02:35:47, Andi Kleen wrote:
> Allow HPET force enable on ICH10 HPET
>
> Intel "Smackover" x58 BIOS don't have HPET enabled in the BIOS, so allow
> to force enable it at least. The register layout is the same
> as in other recent ICHs, so all the code can be reused.
>
> Using numerical PCI-ID because it's unlikely the PCI-ID will be used
> anywhere else.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Why not fix it properly... in the BIOS?
> @@ -170,7 +170,8 @@
> ich_force_enable_hpet);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9_7,
> ich_force_enable_hpet);
> -
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x3a16, /* ICH10 */
> + ich_force_enable_hpet);
>
> static struct pci_dev *cached_dev;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2008-12-18 7:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 1:35 [PATCH] Allow HPET force enable on ICH10 HPET Andi Kleen
2008-12-18 7:33 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218073304.GA2110@ucw.cz \
--to=pavel@suse.cz \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox