From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Alexander van Heukelum <heukelum@fastmail.fm>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Jan Beulich <jbeulich@novell.com>,
linux-arch@vger.kernel.org,
Alexander van Heukelum <heukelum@mailshack.com>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/many] PROC macro to annotate functions in assembly files
Date: Thu, 18 Dec 2008 10:07:47 +0000 [thread overview]
Message-ID: <20081218100747.GA10593@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1229593918.31758.1290707307@webmail.messagingengine.com>
On Thu, Dec 18, 2008 at 10:51:58AM +0100, Alexander van Heukelum wrote:
> Agreed. I vote to complement the existing ENDPROC annotation with
> the proposed PROC annotation. Let's call that an extension, not
> something new ;). As it stands it is not impossible to go with
> ENTRY/ENDPROC for code and ENTRY/END for data. However, ENTRY
> implies alignment and the prefered alignment for code and data
> might differ.
Have you looked at the number of ENTRY uses for code vs for data?
If all you're after is separating the two uses, then it might be a
smaller patch to change the ENTRY use for data rather than changing
all the ENTRY uses for code.
There are 589 uses of ENTRY in arch/arm/*/*.S. Of those about 50
aren't called code.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2008-12-18 10:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 9:17 PROC macro to annotate functions in assembly files Alexander van Heukelum
2008-12-17 9:17 ` [PATCH 1/many] " Alexander van Heukelum
2008-12-17 9:17 ` [PATCH last/many] x86: checking framework for correct use of ENTRY/PROC Alexander van Heukelum
2008-12-17 11:51 ` Cyrill Gorcunov
2008-12-17 12:04 ` Alexander van Heukelum
2008-12-17 14:43 ` Cyrill Gorcunov
2008-12-17 17:26 ` [PATCH 1/many] PROC macro to annotate functions in assembly files Sam Ravnborg
2008-12-17 17:38 ` Cyrill Gorcunov
2008-12-17 18:00 ` Sam Ravnborg
2008-12-17 18:33 ` Cyrill Gorcunov
2008-12-18 9:51 ` Alexander van Heukelum
2008-12-18 10:07 ` Russell King [this message]
2008-12-18 11:30 ` Alexander van Heukelum
2008-12-18 10:20 ` Jan Beulich
2008-12-18 12:03 ` Cyrill Gorcunov
2008-12-18 12:40 ` Alexander van Heukelum
2008-12-18 16:05 ` Cyrill Gorcunov
2008-12-18 9:23 ` Alexander van Heukelum
2008-12-18 12:52 ` Ingo Molnar
2008-12-17 10:53 ` David Howells
2008-12-17 11:12 ` Alexander van Heukelum
2008-12-18 11:44 ` Russell King
2008-12-18 12:35 ` Alexander van Heukelum
2008-12-18 15:53 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218100747.GA10593@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=heukelum@fastmail.fm \
--cc=heukelum@mailshack.com \
--cc=jbeulich@novell.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox