public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	viro@ftp.linux.org.uk, linux-kernel@vger.kernel.org,
	xen-devel@lists.xensource.com, alex.zeffertt@eu.citrix.com,
	Ian.Campbell@citrix.com
Subject: Re: [PATCH UPDATED] xen: add xenfs to allow usermode <-> Xen interaction
Date: Thu, 18 Dec 2008 14:18:12 +0100	[thread overview]
Message-ID: <20081218131812.GD32135@elte.hu> (raw)
In-Reply-To: <20081217133429.b64e6421.akpm@linux-foundation.org>


* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Wed, 17 Dec 2008 13:24:39 -0800
> Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> 
> > The xenfs filesystem exports various interfaces to usermode.  Initially
> > this exports a file to allow usermode to interact with xenbus/xenstore.
> > 
> > Traditionally this appeared in /proc/xen.  Rather than extending procfs,
> > this patch adds a backward-compat mountpoint on /proc/xen, and provides
> > a xenfs filesystem which can be mounted there.
> > 
> > [ 
> >   I did quite a lot of work to this code as a result of review, which is
> >   why this is a repost rather than a delta.  The changes are:
> > 
> >    - Moved the XENFS_SUPER_MAGIC to linux/magic.h
> >    - Added comments to answer the "what's this for?" questions (I hope)
> >    - Split things out into smaller functions
> >    - Cleaned up type of queue_reply(), removed casts
> >    - Added a mutex to protect struct xenbus_file_priv.  This protects
> >       the list heads, and the partial message buffer.  There were
> >       several ways in which usermode could overwrite the kernel's
> >       memory via races without this locking.
> >    - Fixed a bug in which usermode could start sending a message
> >       which can never be sent, leaving the file descriptor in a
> >       useless state.
> 
> I'm bored of your filesystem, so I think I'll just merge it, unless
> someone else wants to ;)

please do - there should be no big overlap with existing other Xen bits in 
tip/*.

	Ingo

  parent reply	other threads:[~2008-12-18 13:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-16 20:27 [PATCH] xen: add xenfs to allow usermode <-> Xen interaction Jeremy Fitzhardinge
2008-12-16 20:46 ` Ingo Molnar
2008-12-16 20:54 ` Andrew Morton
2008-12-16 22:43   ` Jeremy Fitzhardinge
2008-12-17 21:24   ` [PATCH UPDATED] " Jeremy Fitzhardinge
2008-12-17 21:34     ` Andrew Morton
2008-12-17 21:50       ` Jeremy Fitzhardinge
2008-12-18 13:18       ` Ingo Molnar [this message]
2008-12-17 21:40     ` [PATCH UPDATED] xen/xenfs: fix xenbus message reads Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081218131812.GD32135@elte.hu \
    --to=mingo@elte.hu \
    --cc=Ian.Campbell@citrix.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.zeffertt@eu.citrix.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox