Re: [patch] cciss: Fix problem that deleting multiple logical drives could cause a panic

Jens Axboe
2008-12-18T13:58:05Z

On Tue, Dec 16 2008, scameron@beardog.cca.cpqcorp.net wrote:
> On Tue, Dec 16, 2008 at 09:27:30PM +0100, Jens Axboe wrote:
> > On Tue, Dec 16 2008, scameron@beardog.cca.cpqcorp.net wrote:
> > >
> > > Fix problem that deleting multiple logical drives could cause a panic.
> >
> > This looks like a 2.6.28 candidate, correct?
>
> Yes, and we would like to get it in anywhere else it needs to go
> (backport to 2.6.27.x? if that makes sense.)
>
> It fixes a panic which can be easily reproduced in the following
> way: Just create several "arrays," each with multiple logical
> drives via hpacucli, then delete the first array, and it will blow
> up in deregister_disk(), in the call to get_host() when it tries to
> dig the hba pointer out of a NULL queue pointer.
>
> The problem has been present since my code to make
> rebuild_lun_table behave better went in.

OK, I'll make sure it goes upstream for 2.6.28. I've merged your other
cciss patch for 2.6.29.

--
Jens Axboe