RE: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn

RE: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn

[Pallipadi, Venkatesh]

Ingo,

Haven't seen any comments on the patches here. Can you push these patches along to tip.

Thanks,
Venki

>-----Original Message-----
>From: Pallipadi, Venkatesh
>Sent: Tuesday, November 25, 2008 4:22 PM
>To: akpm@linux-foundation.org; npiggin@suse.de;
>hugh@veritas.com; mingo@elte.hu; hpa@zytor.com; tglx@linutronix.de
>Cc: rdreier@cisco.com; jeremy@goop.org;
>jbarnes@virtuousgeek.org; arjan@infradead.org; linux-kernel@;
>Siddha, Suresh B
>Subject: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with
>remap_pfn_range and vm_insert_pfn
>
>Followup for the patches posted earlier here:
>http://marc.info/?l=linux-kernel&m=122653213110404&w=2
>
>Drivers use mmap followed by pgprot_* and remap_pfn_range or
>vm_insert_pfn,
>in order to export reserved memory to userspace. Currently,
>such mappings are
>not tracked and hence not kept consistent with other mappings
>(/dev/mem,
>pci resource, ioremap) for the sme memory, that may exist in
>the system.
>
>The following patchset adds x86 PAT attribute tracking and
>untracking for
>pfnmap related APIs.
>
>First three patches in the patchset are changing the generic
>mm code to fit
>in this tracking. Last four patches are x86 specific to make
>things work
>with x86 PAT code. The patchset aso introduces
>pgprot_writecombine interface,
>which gives writecombine mapping when enabled, falling back to
>pgprot_noncached otherwise.
>
>
>--
>
>

Re: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn

[Ingo Molnar]

* Pallipadi, Venkatesh <venkatesh.pallipadi@intel.com> wrote:

> Ingo,
> 
> Haven't seen any comments on the patches here. Can you push these 
> patches along to tip.

while the main focus of the changes are x86, they touch the MM 
non-trivially too:

   include/linux/mm.h |    9 +++++++++
   mm/memory.c        |    7 +++----
   2 files changed, 12 insertions(+), 4 deletions(-)

   mm/memory.c |    2 ++
   1 file changed, 2 insertions(+)

   include/linux/mm.h |    3 +++
   mm/memory.c        |   43 +++++++++++++++++++++++++++++++++++++++++++
   2 files changed, 46 insertions(+)

   include/linux/mm.h |    6 +++++
   mm/memory.c        |   54 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
   2 files changed, 59 insertions(+), 1 deletion(-)

So when you sent this a month ago i asked the MM folks whether they have 
any problems with these patches. Acks (or objections) from Andrew, Nick or 
Hugh would be nice to have.

	Ingo

Re: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn

[Nick Piggin]

On Tue, Dec 16, 2008 at 08:51:54PM +0100, Ingo Molnar wrote:
> 
> * Pallipadi, Venkatesh <venkatesh.pallipadi@intel.com> wrote:
> 
> > Ingo,
> > 
> > Haven't seen any comments on the patches here. Can you push these 
> > patches along to tip.
> 
> while the main focus of the changes are x86, they touch the MM 
> non-trivially too:
> 
>    include/linux/mm.h |    9 +++++++++
>    mm/memory.c        |    7 +++----
>    2 files changed, 12 insertions(+), 4 deletions(-)
> 
>    mm/memory.c |    2 ++
>    1 file changed, 2 insertions(+)
> 
>    include/linux/mm.h |    3 +++
>    mm/memory.c        |   43 +++++++++++++++++++++++++++++++++++++++++++
>    2 files changed, 46 insertions(+)
> 
>    include/linux/mm.h |    6 +++++
>    mm/memory.c        |   54 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
>    2 files changed, 59 insertions(+), 1 deletion(-)
> 
> So when you sent this a month ago i asked the MM folks whether they have 
> any problems with these patches. Acks (or objections) from Andrew, Nick or 
> Hugh would be nice to have.

Last I looked at them, I think all my questions were cleared up.

Re: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn

[Ingo Molnar]

* Nick Piggin <npiggin@suse.de> wrote:

> On Tue, Dec 16, 2008 at 08:51:54PM +0100, Ingo Molnar wrote:
> > 
> > * Pallipadi, Venkatesh <venkatesh.pallipadi@intel.com> wrote:
> > 
> > > Ingo,
> > > 
> > > Haven't seen any comments on the patches here. Can you push these 
> > > patches along to tip.
> > 
> > while the main focus of the changes are x86, they touch the MM 
> > non-trivially too:
> > 
> >    include/linux/mm.h |    9 +++++++++
> >    mm/memory.c        |    7 +++----
> >    2 files changed, 12 insertions(+), 4 deletions(-)
> > 
> >    mm/memory.c |    2 ++
> >    1 file changed, 2 insertions(+)
> > 
> >    include/linux/mm.h |    3 +++
> >    mm/memory.c        |   43 +++++++++++++++++++++++++++++++++++++++++++
> >    2 files changed, 46 insertions(+)
> > 
> >    include/linux/mm.h |    6 +++++
> >    mm/memory.c        |   54 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
> >    2 files changed, 59 insertions(+), 1 deletion(-)
> > 
> > So when you sent this a month ago i asked the MM folks whether they have 
> > any problems with these patches. Acks (or objections) from Andrew, Nick or 
> > Hugh would be nice to have.
> 
> Last I looked at them, I think all my questions were cleared up.

does that transform into a:

  Acked-by: Nick Piggin <npiggin@suse.de>

? :-)

	Ingo

Re: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn

[Nick Piggin]

On Tue, Dec 16, 2008 at 11:07:46PM +0100, Ingo Molnar wrote:
> 
> * Nick Piggin <npiggin@suse.de> wrote:
> > > So when you sent this a month ago i asked the MM folks whether they have 
> > > any problems with these patches. Acks (or objections) from Andrew, Nick or 
> > > Hugh would be nice to have.
> > 
> > Last I looked at them, I think all my questions were cleared up.
> 
> does that transform into a:
> 
>   Acked-by: Nick Piggin <npiggin@suse.de>

I should think so ;), but I'll take another glance at the next round
after Andrew's comments were incorporated. Are those available?

Re: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn

[Ingo Molnar]

* Nick Piggin <npiggin@suse.de> wrote:

> On Tue, Dec 16, 2008 at 11:07:46PM +0100, Ingo Molnar wrote:
> > 
> > * Nick Piggin <npiggin@suse.de> wrote:
> > > > So when you sent this a month ago i asked the MM folks whether they have 
> > > > any problems with these patches. Acks (or objections) from Andrew, Nick or 
> > > > Hugh would be nice to have.
> > > 
> > > Last I looked at them, I think all my questions were cleared up.
> > 
> > does that transform into a:
> > 
> >   Acked-by: Nick Piggin <npiggin@suse.de>
> 
> I should think so ;), but I'll take another glance at the next round 
> after Andrew's comments were incorporated. Are those available?

not yet available - Venki, would you mind to resend the series with those 
bits fixed, so that Nick can have a look at the end result? Thanks,

	Ingo

RE: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn

[Pallipadi, Venkatesh]

 

>-----Original Message-----
>From: Ingo Molnar [mailto:mingo@elte.hu] 
>Sent: Thursday, December 18, 2008 6:32 AM
>To: Nick Piggin
>Cc: Pallipadi, Venkatesh; Andrew Morton; Hugh Dickins; 
>hpa@zytor.com; tglx@linutronix.de; linux-kernel@vger.kernel.org
>Subject: Re: [patch 0/7] x86 PAT: v2 - track pfnmap mappings 
>with remap_pfn_range and vm_insert_pfn
>
>
>* Nick Piggin <npiggin@suse.de> wrote:
>
>> On Tue, Dec 16, 2008 at 11:07:46PM +0100, Ingo Molnar wrote:
>> > 
>> > * Nick Piggin <npiggin@suse.de> wrote:
>> > > > So when you sent this a month ago i asked the MM folks 
>whether they have 
>> > > > any problems with these patches. Acks (or objections) 
>from Andrew, Nick or 
>> > > > Hugh would be nice to have.
>> > > 
>> > > Last I looked at them, I think all my questions were cleared up.
>> > 
>> > does that transform into a:
>> > 
>> >   Acked-by: Nick Piggin <npiggin@suse.de>
>> 
>> I should think so ;), but I'll take another glance at the next round 
>> after Andrew's comments were incorporated. Are those available?
>
>not yet available - Venki, would you mind to resend the series 
>with those 
>bits fixed, so that Nick can have a look at the end result? Thanks,
>

Yes. Working on it right now and should have it later today..

Thanks,
Venki