From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh <jaswinderlinux@gmail.com>
Cc: Jaswinder Singh <jaswinder@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] x86: traps.c declare functions before they get used
Date: Thu, 18 Dec 2008 15:33:35 +0100 [thread overview]
Message-ID: <20081218143335.GA10548@elte.hu> (raw)
In-Reply-To: <3f9a31f40812162028j5a0e12f5h2215daae12ce3441@mail.gmail.com>
* Jaswinder Singh <jaswinderlinux@gmail.com> wrote:
> Hello Ingo,
>
> On Wed, Dec 17, 2008 at 1:49 AM, Ingo Molnar <mingo@elte.hu> wrote:
> >> +#ifndef CONFIG_MATH_EMULATION
> >> asmlinkage void math_emulate(long);
> >> #endif
> >
> > uhm, shouldnt that #ifndef CONFIG_MATH_EMULATION be #ifdef
> > CONFIG_MATH_EMULATION?
> >
>
> Sorry, but it seems correct to me in traps case will be opposite.
>
> If someone tries to access math_emulate() and MATH_EMULATION is not
> defined then he will be trapped ;-)
you should build-test your patch with MATH_EMULATION enabled.
Ingo
next prev parent reply other threads:[~2008-12-18 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 16:55 [PATCH] x86: traps.c declare functions before they get used Jaswinder Singh
2008-12-16 20:19 ` Ingo Molnar
2008-12-17 4:28 ` Jaswinder Singh
2008-12-18 14:33 ` Ingo Molnar [this message]
2008-12-18 18:33 ` Jaswinder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218143335.GA10548@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=jaswinder@infradead.org \
--cc=jaswinderlinux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox