From: Pavel Machek <pavel@suse.cz>
To: Len Brown <lenb@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: acpi_os_allocate(GFP_KERNEL) (was Re: acpi_evaluate_integer broken by design)
Date: Thu, 18 Dec 2008 17:48:01 +0100 [thread overview]
Message-ID: <20081218164801.GC16115@elf.ucw.cz> (raw)
In-Reply-To: <alpine.LFD.2.00.0812180104500.17738@localhost.localdomain>
On Thu 2008-12-18 01:07:08, Len Brown wrote:
>
>
> -- Len Brown, Intel Open Source Technology Center
>
> > In fact, we should be using GFP_ATOMIC already while devices are being
> > suspended, so we can switch from GFP_KERNEL to GFP_ATOMIC even before
> > interrupts are enabled.
>
> true. it makes me wonder if tinkering with ACPI
> is a bad idea -- for it will address only one user of kmalloc.
Other users should already know that they are called while suspending
device, and behave accordingly (use right flags to kmalloc, etc.)
If not, that's a bug...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-12-18 16:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 11:05 acpi_evaluate_integer broken by design Pavel Machek
2008-11-25 18:41 ` Moore, Robert
2008-11-26 21:20 ` Andrew Morton
2008-11-26 22:37 ` Len Brown
2008-11-26 23:02 ` Andrew Morton
2008-11-27 13:58 ` Pavel Machek
2008-12-16 5:24 ` acpi_os_allocate(GFP_KERNEL) (was Re: acpi_evaluate_integer broken by design) Len Brown
2008-12-16 5:41 ` Andrew Morton
2008-12-16 15:34 ` Rafael J. Wysocki
2008-12-16 23:40 ` Rafael J. Wysocki
2008-12-16 23:49 ` Rafael J. Wysocki
2008-12-18 6:07 ` Len Brown
2008-12-18 16:48 ` Pavel Machek [this message]
2008-12-18 6:08 ` irqs_disabled() vs ACPI interpreter vs suspend Len Brown
2008-12-18 16:32 ` Rafael J. Wysocki
2008-12-18 16:52 ` Pavel Machek
2008-12-18 21:20 ` Rafael J. Wysocki
2008-12-18 16:55 ` Pavel Machek
2008-11-27 13:56 ` acpi_evaluate_integer broken by design Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218164801.GC16115@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=johannes@sipsolutions.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox