From: Ingo Molnar <mingo@elte.hu>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: sigframe.h: add guard macro
Date: Thu, 18 Dec 2008 22:06:28 +0100 [thread overview]
Message-ID: <20081218210628.GC24271@elte.hu> (raw)
In-Reply-To: <494A85EB.9010505@ct.jp.nec.com>
* Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> Impact: cleanup
>
> Add missing guard macro _ASM_X86_SIGFRAME_H.
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> ---
> I forgot include guard:)
>
> arch/x86/include/asm/sigframe.h | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
applied, thanks!
It didnt matter in practice yet, because all uses of sigframe.h were
single-instance and were done in flat .c files, not in .h files:
./arch/x86/kernel/asm-offsets_32.c:#include "sigframe.h"
./arch/x86/kernel/signal_32.c:#include "sigframe.h"
./arch/x86/kernel/signal_64.c:#include "sigframe.h"
./arch/x86/ia32/ia32_signal.c: struct _fpstate_ia32 fpstate_unused; /* look at kernel/sigframe.h */
but indeed it's better to have this fixed - just in case we put sigframe.h
into an include file.
Ingo
prev parent reply other threads:[~2008-12-18 21:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 2:47 [PATCH 1/6] x86: signal: move ia32 func declarations into arch/x86/kernel/signal.c Hiroshi Shimamoto
2008-12-18 2:49 ` [PATCH 2/6] x86: signal: rename sigframe and rt_sigframe on 32-bit Hiroshi Shimamoto
2008-12-18 2:50 ` [PATCH 3/6] x86: signal: move sigframe.h to arch/x86/include/asm Hiroshi Shimamoto
2008-12-18 2:51 ` [PATCH 4/6] x86: signal: prepare to include from ia32_signal.c Hiroshi Shimamoto
2008-12-18 2:51 ` [PATCH 5/6] x86: ia32_signal: rename struct sigframe and rt_sigframe Hiroshi Shimamoto
2008-12-18 2:52 ` [PATCH 6/6] x86: ia32_signal: use sigframe.h Hiroshi Shimamoto
2008-12-18 10:29 ` [PATCH 1/6] x86: signal: move ia32 func declarations into arch/x86/kernel/signal.c Ingo Molnar
2008-12-18 17:18 ` [PATCH] x86: sigframe.h: add guard macro Hiroshi Shimamoto
2008-12-18 21:06 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218210628.GC24271@elte.hu \
--to=mingo@elte.hu \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox