From: Zhenwen Xu <helight.xu@gmail.com>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix some code style that line over 80 characters
Date: Fri, 19 Dec 2008 14:34:15 +0800 [thread overview]
Message-ID: <20081219063415.GB3309@helight> (raw)
In-Reply-To: <20081218193059.GA31274@flint.arm.linux.org.uk>
On Thu, Dec 18, 2008 at 07:30:59PM +0000, Russell King wrote:
> On Thu, Dec 18, 2008 at 11:26:17AM -0800, Randy Dunlap wrote:
> > On Wed, 10 Dec 2008 18:01:16 +0300 Alexey Dobriyan wrote:
> >
> > > On Wed, Dec 10, 2008 at 09:51:43PM +0800, Helight.Xu wrote:
> > > > -static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> > > > +static inline struct
> > > > +s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> > >
> > > NAK!
> >
> > OK, but please includes reason(s) for NAKs...
>
> I can provide a reason - it splits "struct" and the structure name
> across different lines. That manes 'struct s3c2410_platform_i2c'
> hard to grep for.
yes, it should be:
static inline
struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
>
> --
> Russell King
> Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
> maintainer of:
--
---------------------------------
Zhenwen Xu - Open and Free
Home Page: http://zhwen.org
My Studio: http://dim4.cn
prev parent reply other threads:[~2008-12-19 6:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 13:51 [PATCH] fix some code style that line over 80 characters Helight.Xu
2008-12-10 15:01 ` Alexey Dobriyan
2008-12-11 7:20 ` Zhenwen Xu
2008-12-18 19:26 ` Randy Dunlap
2008-12-18 19:30 ` Russell King
2008-12-19 6:34 ` Zhenwen Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081219063415.GB3309@helight \
--to=helight.xu@gmail.com \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox