From: Oleg Nesterov <oleg@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Eric Sesterhenn <snakebyte@gmx.de>,
LKML <linux-kernel@vger.kernel.org>,
John Stultz <johnstul@us.ibm.com>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [BUG] Null pointer deref with hrtimer_try_to_cancel()
Date: Sat, 20 Dec 2008 22:04:01 +0100 [thread overview]
Message-ID: <20081220210401.GA14447@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0812202117310.3376@localhost.localdomain>
On 12/20, Thomas Gleixner wrote:
>
> +static int no_timer_create(struct k_itimer *new_timer)
> +{
> + return -EOPNOTSUPP;
> +}
> +
> /*
> * Return nonzero if we know a priori this clockid_t value is bogus.
> */
> @@ -248,6 +253,7 @@ static __init int init_posix_timers(void)
> .clock_getres = hrtimer_get_res,
> .clock_get = posix_get_monotonic_raw,
> .clock_set = do_posix_clock_nosettime,
> + .timer_create = no_timer_create,
Agreed, this patch is better than mine (and thanks for your
explanation about CLOCK_MONOTONIC_RAW).
I am not sure about -EOPNOTSUPP. To clarify, I do not claim this
is wrong, I just do not know.
But please note that sys_timer_create() does:
if (invalid_clockid(which_clock))
return -EINVAL;
And ltp's timer_create04.c expects timer_create(MAX_CLOCKS == 4)
returns -EINVAL.
Oleg.
next prev parent reply other threads:[~2008-12-20 21:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 17:25 [BUG] Null pointer deref with hrtimer_try_to_cancel() Eric Sesterhenn
2008-12-19 21:48 ` Thomas Gleixner
2008-12-20 16:14 ` Oleg Nesterov
2008-12-20 16:30 ` Oleg Nesterov
2008-12-20 17:48 ` [PATCH] posix-timers: CLOCK_MONOTONIC_RAW: fix the usage of ->it_clock Oleg Nesterov
2008-12-20 20:10 ` Thomas Gleixner
2008-12-20 20:24 ` Oleg Nesterov
2008-12-20 20:37 ` Thomas Gleixner
2008-12-20 20:27 ` [BUG] Null pointer deref with hrtimer_try_to_cancel() Thomas Gleixner
2008-12-20 21:04 ` Oleg Nesterov [this message]
2008-12-21 8:53 ` Thomas Gleixner
2008-12-20 21:38 ` Eric Sesterhenn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081220210401.GA14447@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=snakebyte@gmx.de \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox