public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Parag Warudkar <parag.lkml@gmail.com>,
	Anssi Hannula <anssi.hannula@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-input@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] USBHID: Make Boot Protocol drivers depend on EMBEDDED
Date: Sun, 21 Dec 2008 14:02:00 -0800	[thread overview]
Message-ID: <20081221140200.40c1fec1.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LNX.1.10.0812212247090.26265@jikos.suse.cz>

On Sun, 21 Dec 2008 22:48:21 +0100 (CET) Jiri Kosina <jkosina@suse.cz> wrote:

> On Sun, 21 Dec 2008, Parag Warudkar wrote:
> 
> > The usbmouse and usbkbd modules are not supposed to be used with regular 
> > USB mice and keyboards. Make them depend on EMBEDDED to prevent them from 
> > being built and loaded on non-EMBEDDED configs.
> > 
> > Signed-off-by: Parag Warudkar <parag.lkml@gmail.com>
> > 
> > diff --git a/drivers/hid/usbhid/Kconfig b/drivers/hid/usbhid/Kconfig
> > index 5d9aa95..4edb3be 100644
> > --- a/drivers/hid/usbhid/Kconfig
> > +++ b/drivers/hid/usbhid/Kconfig
> > @@ -45,7 +45,7 @@ config USB_HIDDEV
> >  	  If unsure, say Y.
> >  
> >  menu "USB HID Boot Protocol drivers"
> > -	depends on USB!=n && USB_HID!=y
> > +	depends on USB!=n && USB_HID!=y && EMBEDDED
> >  
> >  config USB_KBD
> >  	tristate "USB HIDBP Keyboard (simple Boot) support"
> 
> So do I get it right that the only reason of the problem you were seeing 
> was that in the 2.6.27 kernel you have compiled usbhid module, which was 
> then used for driving your mouse,but in 2.6.28-rcX you compiled and used 
> 'usbmouse' instead, and therefore this is not a regression?
> 

Shouldn't usbmouse support two-dimensional mice as well?

  reply	other threads:[~2008-12-21 22:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-21  3:11 2.6.28-rc9: USB Mouse unhappy Parag Warudkar
2008-12-21  6:12 ` Andrew Morton
2008-12-21  6:26   ` Parag Warudkar
2008-12-21 10:56     ` Anssi Hannula
2008-12-21 15:17       ` Parag Warudkar
2008-12-21 17:30         ` Jiri Kosina
2008-12-21 18:39           ` Jiri Kosina
2009-01-09 23:11             ` Rafael J. Wysocki
2009-01-09 23:18               ` Parag Warudkar
2009-01-09 23:19               ` Jiri Kosina
2009-01-10  0:19                 ` Rafael J. Wysocki
2008-12-21 19:49           ` [PATCH] USBHID: Make Boot Protocol drivers depend on EMBEDDED Parag Warudkar
2008-12-21 21:48             ` Jiri Kosina
2008-12-21 22:02               ` Andrew Morton [this message]
2008-12-21 22:03                 ` Jiri Kosina
2008-12-21 22:12                   ` Parag Warudkar
2008-12-21 22:17                     ` Anssi Hannula
2008-12-21 22:23                       ` Parag Warudkar
2008-12-21 22:44                         ` Jiri Kosina
2008-12-21 23:55                           ` Parag Warudkar
2008-12-22 21:52             ` Jiri Kosina
2008-12-21 17:24 ` 2.6.28-rc9: USB Mouse unhappy Jiri Kosina
2008-12-21 18:22   ` Parag Warudkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081221140200.40c1fec1.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=anssi.hannula@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=parag.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox