From: David Brownell <david-b@pacbell.net>
To: me@felipebalbi.com
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
gregkh@suse.de, felipe.balbi@nokia.com,
davinci-linux-open-source@linux.davincidsp.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] musb: fix DaVinci build again
Date: Tue, 23 Dec 2008 19:52:15 -0800 [thread overview]
Message-ID: <200812231952.16171.david-b@pacbell.net> (raw)
In-Reply-To: <20081224022757.GA10240@frodo>
On Tuesday 23 December 2008, Felipe Balbi wrote:
> > #include <linux/gpio.h>
> > +#include <linux/gpio.h>
>
> you're including <linux/gpio.h> twice.
Yeah, I suppose I just edited the patch to
delete segments that *did* get merged. It
looks like that change to <linux/gpio.h> got
included, and "patch" didn't complain ...
leaving the puzzle of just why the *rest* of
that pre-2.6.27 build fix still hasn't merged.
A double inclusion is a minor-but-harmless
annoyance. Those <asm/arch/...> ==> <mach/...>
header changes were mostly merged by 2.6.27-rc2,
but ones for this particular file got stripped
out. More than a small bit puzzling; I can
understand patches getting dropped or lost,
but not getting mangled like that.
When I verify that I have a kernel booting
on the DM6446 EVM in mainline, I'll resend
both of the patches. They are IMO overdue
to merge.
next prev parent reply other threads:[~2008-12-24 3:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200812072341.50012.sshtylyov@ru.mvista.com>
[not found] ` <494A7729.6090102@ru.mvista.com>
[not found] ` <494A7809.1040504@ru.mvista.com>
[not found] ` <494E2450.9080601@ru.mvista.com>
2008-12-23 11:46 ` [PATCH] musb: fix DaVinci build again Sergei Shtylyov
2008-12-23 17:38 ` David Brownell
2008-12-23 23:23 ` Sergei Shtylyov
2008-12-24 1:07 ` David Brownell
2008-12-24 2:27 ` Felipe Balbi
2008-12-24 3:52 ` David Brownell [this message]
2008-12-25 20:37 ` David Brownell
2008-12-24 15:04 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812231952.16171.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=felipe.balbi@nokia.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox